-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SITE-2457] Reload core during post schema. #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need two things... 1. Change the way it gets the reload URL to the environment variable. 2. do a command to do the reload from drush.
Also having a drush command will help you debug the process once we get to testing. Once you know the drush command works and you can trigger it at will, you can know that as long as the UI is triggering that function, all is working as it should. |
I'm unsure whether reloading as a standalone command is needed/makes sense. AFAIK the goal is to make reload happen automatically on schema post |
Co-authored-by: Phil Tyler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been a number of hands on this. +1 to cut a release and get a fix out with the caveat that unit tests are failing (and were failing before this PR) and units are not running in CI.
exception throwing in code from a6b1488
I've backed out the changes to PantheonSolrConnector (a6b1488 and its subsequent fixes), as we encountered an exception thrown from the dash running reload core at
|
This reverts commit 41de021.
fixing exception
…oster" This reverts commit b1e21d8.
Replacing this with #192. |
reloadCore()
instead of the no-op log.