Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITE-2457] Reload core during post schema. #189

Closed
wants to merge 36 commits into from
Closed

Conversation

kporras07
Copy link
Contributor

@kporras07 kporras07 commented Nov 8, 2024

  • Reloads schema after schema is posted
  • Adds reload terminus command
  • calls new reload endpoint as part of reloadCore() instead of the no-op log.

@pwtyler pwtyler changed the title First attempt to reload core during post schema. [SITE-2457] First attempt to reload core during post schema. Nov 12, 2024
stovak
stovak previously requested changes Nov 12, 2024
Copy link
Member

@stovak stovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need two things... 1. Change the way it gets the reload URL to the environment variable. 2. do a command to do the reload from drush.

src/Services/Endpoint.php Show resolved Hide resolved
src/Services/SchemaPoster.php Show resolved Hide resolved
@stovak
Copy link
Member

stovak commented Nov 12, 2024

Also having a drush command will help you debug the process once we get to testing. Once you know the drush command works and you can trigger it at will, you can know that as long as the UI is triggering that function, all is working as it should.

@kporras07
Copy link
Contributor Author

I'm unsure whether reloading as a standalone command is needed/makes sense. AFAIK the goal is to make reload happen automatically on schema post

@pwtyler pwtyler changed the title [SITE-2457] First attempt to reload core during post schema. [SITE-2457] Reload core during post schema. Nov 12, 2024
.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Phil Tyler <[email protected]>
@stovak stovak marked this pull request as ready for review November 13, 2024 01:29
@stovak stovak requested a review from a team as a code owner November 13, 2024 01:29
@stovak stovak self-requested a review November 13, 2024 01:30
pwtyler
pwtyler previously approved these changes Nov 13, 2024
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been a number of hands on this. +1 to cut a release and get a fix out with the caveat that unit tests are failing (and were failing before this PR) and units are not running in CI.

@pwtyler pwtyler dismissed their stale review November 13, 2024 05:29

exception throwing in code from a6b1488

@pwtyler
Copy link
Member

pwtyler commented Nov 13, 2024

I've backed out the changes to PantheonSolrConnector (a6b1488 and its subsequent fixes), as we encountered an exception thrown from the dash running reload core at /admin/config/search/search-api/server/pantheon_blog_solr8/solr-admin/reload-core.

Message	RuntimeException: Unable to instantiate Schema Poster. in Drupal\search_api_pantheon\Plugin\SolrConnector\PantheonSolrConnector->reloadCore() (line 409 of /code/web/modules/contrib/search_api_pantheon/src/Plugin/SolrConnector/PantheonSolrConnector.php).

drush search-api-pantheon:postSchema and /admin/config/search/search-api/server/pantheon_solr8/pantheon-admin/schema seem fine though. still adovcating Reload Core may be best as follow-on work unless there's an important gap I'm missing here.

pwtyler
pwtyler previously approved these changes Nov 13, 2024
namespacebrian
namespacebrian previously approved these changes Nov 13, 2024
@pwtyler pwtyler dismissed stale reviews from namespacebrian and themself November 13, 2024 19:23

fixing exception

@pwtyler
Copy link
Member

pwtyler commented Nov 14, 2024

Replacing this with #192. git diff c4383b0 65a5c94 shows no difference. That PR will be our workspace for future iteration on the currently broken "reload core".

@pwtyler pwtyler closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants