Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Bump rubocop from 1.38.0 to 1.51.0 #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 15, 2023

Bumps rubocop from 1.38.0 to 1.51.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.51 (The RubyKaigi 2023 Edition)

New features

Bug fixes

  • #11812: Fix a false negative for Style/Attr when using attr and method definitions. (@​koic)
  • #11861: Fix a false positive for Layout/SpaceAfterSemicolon when no space between a semicolon and a closing brace of string interpolation. (@​koic)
  • #11830: Fix a false positive for Lint/IncompatibleIoSelectWithFiberScheduler. (@​koic)
  • #11846: Fix a false positive for Lint/RedundantStringCoercion when using to_s(argument) in puts argument. (@​koic)
  • #11865: Fix an error for Naming/ConstantName when assigning a constant from an empty branch of else. (@​koic)
  • #11844: Fix a false positive for Style/RedundantLineContinuation when using line concatenation for assigning a return value and without argument parentheses. (@​koic)
  • #11808: Fix a false positive for Style/RegexpLiteral when using a regexp starts with equal as a method argument. (@​koic)
  • #11822: Fix an error for Layout/SpaceInsideBlockBraces when a method call with a multiline block is used as an argument. (@​koic)
  • #11849: Fix an error for Style/ConditionalAssignment when EnforcedStyle: assign_inside_condition and using empty case condition. (@​koic)
  • #11967: Fix error for Style/IfInsideElse when a deep nested multiline if...then...elsif...else...end. (@​koic)
  • #11842: Fix an error for Style/IfUnlessModifier when using multiple if modifier in the long one line. (@​koic)
  • #11835: Fix an error for Style/RequireOrder when multiple require are not sorted. (@​koic)
  • #11809: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when exception variable is referenced after rescue statement. (@​koic)
  • #11852: Fix an incorrect autocorrect for Style/EvalWithLocation when using eval without line number and with parenthesized method call. (@​koic)
  • #11862: Fix an incorrect autocorrect for Style/GuardClause when using raise in else branch in a one-liner with then. (@​koic)
  • #11868: Fix a false positive for Style/HashExcept when method's receiver/argument is not the same as block key argument. (@​fatkodima)
  • #11858: Fix false positives when using source comments in blocks. (@​reitermarkus)
  • #11510: Fix Lint/UselessAssignment false positive when using numbered block parameters. (@​sambostock)
  • #11872: Fix Gemspec/DevelopmentDependencies not trigger when add_development_dependency has more then one arguments. (@​Bhacaz)
  • #11820: Fix Lint/EmptyConditionalBody false-positives for commented empty elsif body. (@​r7kamura)

Changes

  • #11859: Add rubocop-factory_bot to suggested extensions. (@​ydah)
  • #10791: (Breaking) Drop runtime support for Ruby 2.6 and JRuby 9.3 (CRuby 2.6 compatible). (@​koic)
  • #11826: Exclude **/*.jb from Lint/TopLevelReturnWithArgument. (@​r7kamura)
  • #11871: Mark Style/DataInheritance as unsafe autocorrect, Style/OpenStructUse as unsafe, and Security/CompoundHash as unsafe. (@​koic)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.51.0 (2023-05-13)

New features

Bug fixes

  • #11812: Fix a false negative for Style/Attr when using attr and method definitions. ([@​koic][])
  • #11861: Fix a false positive for Layout/SpaceAfterSemicolon when no space between a semicolon and a closing brace of string interpolation. ([@​koic][])
  • #11830: Fix a false positive for Lint/IncompatibleIoSelectWithFiberScheduler. ([@​koic][])
  • #11846: Fix a false positive for Lint/RedundantStringCoercion when using to_s(argument) in puts argument. ([@​koic][])
  • #11865: Fix an error for Naming/ConstantName when assigning a constant from an empty branch of else. ([@​koic][])
  • #11844: Fix a false positive for Style/RedundantLineContinuation when using line concatenation for assigning a return value and without argument parentheses. ([@​koic][])
  • #11808: Fix a false positive for Style/RegexpLiteral when using a regexp starts with equal as a method argument. ([@​koic][])
  • #11822: Fix an error for Layout/SpaceInsideBlockBraces when a method call with a multiline block is used as an argument. ([@​koic][])
  • #11849: Fix an error for Style/ConditionalAssignment when EnforcedStyle: assign_inside_condition and using empty case condition. ([@​koic][])
  • #11967: Fix error for Style/IfInsideElse when a deep nested multiline if...then...elsif...else...end. ([@​koic][])
  • #11842: Fix an error for Style/IfUnlessModifier when using multiple if modifier in the long one line. ([@​koic][])
  • #11835: Fix an error for Style/RequireOrder when multiple require are not sorted. ([@​koic][])
  • #11809: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when exception variable is referenced after rescue statement. ([@​koic][])
  • #11852: Fix an incorrect autocorrect for Style/EvalWithLocation when using eval without line number and with parenthesized method call. ([@​koic][])
  • #11862: Fix an incorrect autocorrect for Style/GuardClause when using raise in else branch in a one-liner with then. ([@​koic][])
  • #11868: Fix a false positive for Style/HashExcept when method's receiver/argument is not the same as block key argument. ([@​fatkodima][])
  • #11858: Fix false positives when using source comments in blocks. ([@​reitermarkus][])
  • #11510: Fix Lint/UselessAssignment false positive when using numbered block parameters. ([@​sambostock][])
  • #11872: Fix Gemspec/DevelopmentDependencies not trigger when add_development_dependency has more then one arguments. ([@​Bhacaz][])
  • #11820: Fix Lint/EmptyConditionalBody false-positives for commented empty elsif body. ([@​r7kamura][])

Changes

  • #11859: Add rubocop-factory_bot to suggested extensions. ([@​ydah][])
  • #10791: (Breaking) Drop runtime support for Ruby 2.6 and JRuby 9.3 (CRuby 2.6 compatible). ([@​koic][])
  • #11826: Exclude **/*.jb from Lint/TopLevelReturnWithArgument. ([@​r7kamura][])
  • #11871: Mark Style/DataInheritance as unsafe autocorrect, Style/OpenStructUse as unsafe, and Security/CompoundHash as unsafe. ([@​koic][])

1.50.2 (2023-04-17)

Bug fixes

  • #11799: Fix a false positive for Style/CollectionCompact when using reject on hash to reject nils in Ruby 2.3 analysis. ([@​koic][])
  • #11792: Fix an error for Lint/DuplicateMatchPattern when using hash pattern with if guard. ([@​koic][])

... (truncated)

Commits
  • a38991d Cut 1.51 to celebrate RubyKaigi 2023
  • 0d04592 Update Changelog
  • 0970cc1 Fix a false positive for Lint/IncompatibleIoSelectWithFiberScheduler
  • 922501f Add new Style/ExactRegexpMatch cop
  • 7cda5ae Mark some cops as unsafe
  • 824441b Merge pull request #11872 from Bhacaz/fix_development_dependencies_cop_with_a...
  • e768851 Fix Gemspec/DevelopmentDependencies not trigger when add_development_dependen...
  • 7ef8629 Merge pull request #11870 from fatkodima/fix-hash_except-incorrect-arguments
  • 1fdb7d6 Fix a false positive for when method's receiver/argument is not the same as ...
  • de330b3 Fix an error for Style/IfInsideElse
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.38.0 to 1.51.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.38.0...v1.51.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file Needs QA labels May 15, 2023
@dependabot dependabot bot requested a review from a team May 15, 2023 04:59
@amymliebs
Copy link
Contributor

We will pause on this until the work to split the panolint repo into panolint-ruby and panolint-rails is complete. Ticket with the status of that work: https://panoramaed.atlassian.net/browse/ACON-18

@cyrorama
Copy link

I added a commit to prevent Dependabot from re-creating this PR.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 5, 2023

A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file Needs QA squad-backlogged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants