New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PHP 8.2 #74

Open

ebitkov wants to merge 4 commits into panique:develop from ebitkov:php82

ebitkov commented Feb 6, 2024

PHP 8.1 is not actively supported anymore. This pull requests aims to update the project to PHP 8.2.

added PHP 8.2 as a requirement to the composer.json (best practice)
added a note to the README to be more precise about the required PHP version
added type hints to the core, controllers and models (best practice)
updated bootstrap.sh (@panique could you review that? I'm not using Vagrant)

Some questions I had while updating

should we add ext-pdo to the composer.json, since we are providing PDO models?
should we switch to const ... instead of define(...) in the application/config/config.php and public/index.php?

ebitkov added 4 commits

February 6, 2024 14:42


          add PHP as a requirement to the composer file

f7d53e0


          update php version

d55524d


          add specific required PHP version to README

c885731


          set type hints

91bd846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet