Backport PR #60321: TST (string dtype): resolve all xfails in IO pars… #60330
+89
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in IO parser tests (cherry picked from commit ee3c18f)
mroeschke
added
Testing
|
Hmm not sure how to fix the failing test here. There's a lot of mutability going on in the CSV parser...but I can trace things back to base_parser.py:510 which calls: index = ensure_index_from_sequences(arrays, names)At that point in time, but the Index constructor seems to force that to @jorisvandenbossche any thoughts on this one? |
|
I have a local fix (have to include changes from #59316 I think), will clean up and push tomorrow |
…andas-dev#59316) * BUG: Avoid RangeIndex conversion in read_csv if dtype is specified * Undo change * Typing
|
@jorisvandenbossche with your added commit I think this is good to merge (?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60321