Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG (string dtype): correctly enable idxmin/max for python-storage strings #60242

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jorisvandenbossche
Copy link
Member

The argmin/argmax methods already work fine on the EAs, but it was not yet properly wired up in EA._reduce for the python storage variant.

xref #54792

@jorisvandenbossche jorisvandenbossche added the Strings String extension data type and string data label Nov 8, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 8, 2024
@WillAyd WillAyd merged commit 754d091 into pandas-dev:main Nov 8, 2024
53 checks passed
Copy link

lumberbot-app bot commented Nov 8, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 754d09163ae08f2b87daa41f2263556dbb809616
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60242: BUG (string dtype): correctly enable idxmin/max for python-storage strings'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60242-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60242 on branch 2.3.x (BUG (string dtype): correctly enable idxmin/max for python-storage strings)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member Author

Manual backport -> #60256

mroeschke pushed a commit that referenced this pull request Nov 8, 2024
…python-storage strings (#60242) (#60256)

BUG (string dtype): correctly enable idxmin/max for python-storage strings (#60242)

(cherry picked from commit 754d091)
ZKaoChi pushed a commit to ZKaoChi/pandas that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants