-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Convert output type in Excel for MultiIndex with period levels #60182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please add tests whenever changing functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - can you also add one test in excel/test_writers.py
for round-tripping (writes a DataFrame to an excel file, reads it, and asserts its the same as the original DataFrame).
My test case gets called 8 times, 6 times the dtype of result is 'datetime64[us]', and the other two times is 'datetime64[s]'. I don't know why this is happening. I had to do unit conversions for result. |
I've found that the dtype of |
And maybe it can be a new issue to unify the units of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note in the whatsnew for v3.0.0 under the I/O section.
Sure. |
@rhshadrach I'm sorry for the trouble, but could you please let me know if there is anything else to change? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @ZKaoChi! |
Thanks a lot for all your help! |
doc/source/whatsnew/v3.0.0.rst
file if fixing a bug or adding a new feature.