BUG: fix #60128 BUG: Series.combine_first loss of precision #60166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Issue: There was int64->float64->int64 conversions - Fix: Carry out the operation without passing through float64
rhshadrach
requested changes
Nov 6, 2024
| @@ -8640,7 +8640,10 @@ def combine( | |||
| """ | |||
| other_idxlen = len(other.index) # save for compare | |||
|
|
|||
| this, other = self.align(other) | |||
| fill_value_for_align = None | |||
| if all(self.dtypes.eq(np.int64)) and all(other.dtypes.eq(np.int64)): | |||
There was a problem hiding this comment.
This needs to be a lot more robust, e.g. can't only be for int64.
|
It seems this needs more general approach, and it would not suitable for a newbie like me. So, I'd like to just close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: There was int64->float64->int64 conversions
Fix: Carry out the operation without passing through float64
closes BUG: Series.combine_first loss of precision #60128
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.