-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create broken-linkcheck.yml #55246
Create broken-linkcheck.yml #55246
Conversation
Created a Github Action to run the Sphinx linkcheck monthly. #45409
Could you make this workflow run in this PR to check the output? |
Could you tell me how to do that ? Do I need to change the yaml code ? |
Yes see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#on or other workflows in this repo |
I changed it to on: |
@pmeier could you see this please ? |
Co-authored-by: Philip Meier <[email protected]>
Co-authored-by: Philip Meier <[email protected]>
Co-authored-by: Philip Meier <[email protected]>
Co-authored-by: Philip Meier <[email protected]>
Co-authored-by: Philip Meier <[email protected]>
Linkcheck failed . It says
|
Sorry, you also need to put pandas/.github/workflows/docbuild-and-upload.yml Lines 33 to 37 in 89bd569
inside the workflow to automatically activate the conda env. |
@pmeier , there are many broken links. How to fix them ? |
@mroeschke , could you look into the pr if anything else to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are many broken links. How to fix them ?
Well, find the source that contains the broken link, and replace it with a working one.
The linkcheck is showing proper output , then why the ci is showing it as failure ?
The whole point of the linkcheck CI is to fail in case there are broken links. Meaning, this PR cannot be merged until the links are fixed.
Alternatively, sphinx-build linkcheck
has options to ignore certain failures. You could also add ignores for all broken links for now and chip away at the ignore list later on. The options need to go into conf.py
.
If I were you, I would probably write a small script to parse the output of the CI run, which you can download here, to automatically create the ignore list.
Co-authored-by: Philip Meier <[email protected]>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@mroeschke , I have worked on your suggestions, please let me know if there are other suggestion. |
@pmeier, could you please look at this linkcheck fail ? |
@ggold7046 your patch resurfaces an issue we had before: #55246 (comment). Plus there seems to be a new broken link that needs to be ignored as well. |
@pmeier , didn't we took care of it already ? |
Well, you "reverted" the patch by applying |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@mroeschke , could you take a look at this PR please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small comments otherwise LGTM
Co-authored-by: Matthew Roeschke <[email protected]>
Thanks @ggold7046 and @pmeier for your patience and effort here |
Created a Github Action to run the Sphinx linkcheck monthly.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.