Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre commit and filter uptream deprecation warnings #38

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add pre commit and filter uptream deprecation warnings #38

wants to merge 3 commits into from

Conversation

paxnovem
Copy link
Contributor

  • Filter warnings that occur in upstream libraries
  • Add precommit hook config

davidism
davidism reviewed May 22, 2024
View reviewed changes
pyproject.toml
@@ -40,6 +40,7 @@ name = "flask_rq"
testpaths = ["tests"]
filterwarnings = [
"error",
"ignore:utcnow:DeprecationWarning",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this from warnings that our own use of datetime generates, or from our dependencies. The syntax is a bit tricky, but try to scope ignores to specific modules so that we don't ignore things in our own code we should be fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidism davidism davidism left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paxnovem @davidism