Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v22.1.0: PVR Add-on API v9.0.0 #116

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

ksooo
Copy link
Collaborator

@ksooo ksooo commented Aug 16, 2024

@palinek could you please set default branch of this repo to Piers. Thanks.
@palinek you seem no longer actively to maintain this addon. Is it obsolete? If yes, I will remove it from Kodi addon repo.

@palinek
Copy link
Owner

palinek commented Aug 16, 2024

could you please set default branch of this repo to Piers. Thanks.

Done.

you seem no longer actively to maintain this addon. Is it obsolete?

Why do you think, it is not maintained? There are no changes recently, but it doesn't mean it is either unmaintened or obsolete.

@ksooo ksooo closed this Aug 16, 2024
@ksooo ksooo reopened this Aug 16, 2024
@palinek
Copy link
Owner

palinek commented Aug 16, 2024

For me it builds and runs OK.
@ksooo is this ready to merge?

@ksooo
Copy link
Collaborator Author

ksooo commented Aug 16, 2024

is this ready to merge?

No. If our Jenkins is not green we cannot release to addon repo.

@palinek
Copy link
Owner

palinek commented Aug 16, 2024

@ksooo Can you, please, rebase on top of current Piers? (I've added the jsoncpp checksum file into repo)

@ksooo
Copy link
Collaborator Author

ksooo commented Aug 16, 2024

please, rebase on top of current Piers

Fixes the github actions build, but not the kodi jenkins build

@palinek
Copy link
Owner

palinek commented Aug 16, 2024

but not the kodi jenkins build

It hasn't been attempted to build yet. Still just scheduled to build.

@ksooo
Copy link
Collaborator Author

ksooo commented Aug 16, 2024

It hasn't been attempted to build yet. Still just scheduled to build.

Right. Now it is also green. :-)

@ksooo ksooo merged commit ca2bf49 into palinek:Piers Aug 16, 2024
2 checks passed
@ksooo ksooo deleted the piers-api-9-0-0 branch August 16, 2024 11:59
@ksooo
Copy link
Collaborator Author

ksooo commented Aug 16, 2024

@palinek you should add the checksum file to Omega branch as well, unless you think there will be no more releases for Omega.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants