-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust compat settings and progress
named argument
#84
Conversation
Project.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also bump the version so that we can immediately tag a release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the version has already been bumped to 0.3.28 (last release was 0.3.27). Am I confused?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added color=:black
in the call to coefplot!
as you requested.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dmbates It seems like there is a bigger problem with recipes in Makie 0.20: I'm going to delay merging this until we get some triage over there. If it looks like recipes are just generally deprecated, I'll rework the implementation to not rely on them. |
@palday Thanks for checking on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palday Is there something I can do to help get this PR in shape to commit?
We seem to be in a convoluted dependency situation w.r.t EmbraceUncertainty. We can't use julia v1.10.0 to render that project unless we allow AlgebraOfGraphics v0.6.18, which includes a fix for the dictionaries issue when using density(). But that will require later versions of Makie than MixedModelsMakie currently allows.
I am willing to devote time to this, including rewriting the density plots in EmbraceUncertainty to avoid AlgebraOfGraphics (I am starting to agree with you that it is easier in the long run to call Makie functions directory and avoid AoG), if you can give me guidance on how to proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coef- and ridgeplots are broken because of the issue I linked above, but I think that's an upstream issue. I can start working on a replacement that doesn't rely on recipes, but there's no reason to block this work on that.
resolution
named argument withsize
in Makie calls. Restrict version ofMakie
to later versions with thesize
named argument.BSplineKit
progress
named argument in call toparametricbootstrap
.We may want to wait for a new release of
CairoMakie
before incorporating these changes. There are warnings in the tests that trace back toCairoMakie
.