Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add device.item to query the inventory #79

Merged
merged 7 commits into from
Oct 18, 2023
Merged

refactor: add device.item to query the inventory #79

merged 7 commits into from
Oct 18, 2023

Conversation

xtimmy86x
Copy link
Contributor

Related Issues

Proposed Changes:

add an item def in the alarm device for query the _inventory

Testing:

Extra Notes (optional):

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@palazzem palazzem assigned palazzem and xtimmy86x and unassigned palazzem Oct 13, 2023
@palazzem palazzem self-requested a review October 13, 2023 15:57
@palazzem palazzem added this to the 2.1.0 milestone Oct 13, 2023
palazzem
palazzem requested changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left just few comments and then we should be good to go!

tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
palazzem
palazzem requested changes Oct 18, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes, and we should be good to move forward!

custom_components/econnect_metronet/binary_sensor.py Show resolved Hide resolved
custom_components/econnect_metronet/binary_sensor.py Outdated Show resolved Hide resolved
custom_components/econnect_metronet/devices.py Outdated Show resolved Hide resolved
tests/test_binary_sensors.py Show resolved Hide resolved
tests/test_binary_sensors.py Show resolved Hide resolved
tests/test_coordinator.py Outdated Show resolved Hide resolved
tests/test_devices.py Show resolved Hide resolved
tests/test_devices.py Show resolved Hide resolved
palazzem
palazzem approved these changes Oct 18, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! we're good to go!

@palazzem palazzem changed the title refactor:add device.item for query the inventory refactor: add device.item to query the inventory Oct 18, 2023
@palazzem palazzem merged commit 55dcdff into palazzem:main Oct 18, 2023
4 checks passed
@xtimmy86x xtimmy86x deleted the xtimmy86x/refactor-4 branch October 18, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees

@xtimmy86x xtimmy86x

Labels
topic:entity type:refactor
Projects
e-Connect Roadmap
Archived in project
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xtimmy86x @palazzem