Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: readme improvements for HomeKit integration #142

Merged
merged 2 commits into from
Feb 16, 2024
Merged

docs: readme improvements for HomeKit integration #142

merged 2 commits into from
Feb 16, 2024

Conversation

andr3a88
Copy link
Contributor

Related Issues

Proposed Changes:

  • Readme improvements for HomeKit integration
  • images folder for screenshots about HomeKit integration

Testing:

  • Review of the changes on README

@andr3a88 andr3a88 marked this pull request as ready for review February 16, 2024 14:10
@palazzem palazzem self-assigned this Feb 16, 2024
@palazzem palazzem added this to the 2.3.0 milestone Feb 16, 2024
palazzem
palazzem requested changes Feb 16, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@palazzem palazzem changed the title Readme improvements for HomeKit integration docs: readme improvements for HomeKit integration Feb 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7935752218

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.862%
Totals Coverage Status
Change from base Build 7935747966: 0.0%
Covered Lines: 622
Relevant Lines: 666
💛 - Coveralls

palazzem
palazzem approved these changes Feb 16, 2024
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @andr3a88 for your feedback and for taking care of the documentation fix!

@palazzem palazzem merged commit 89a16d9 into palazzem:main Feb 16, 2024
5 checks passed
@palazzem palazzem mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees

@palazzem palazzem

Labels
topic:docs type:fix
Projects
e-Connect Roadmap
Archived in project
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andr3a88 @coveralls @palazzem