fix(config): allow users to remove configuration for alarm modes (#35)

#35
palazzem · Sep 8, 2023 · 3947e00 · 3947e00
1 parent 6249eba
commit 3947e00
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/custom_components/econnect_alarm/helpers.py b/custom_components/econnect_alarm/helpers.py
@@ -34,6 +34,10 @@ def parse_areas_config(config: str, raises: bool = False):
         >>> parse_areas_config("3,a")
         []
     """
+    if config == "" or config is None:
+        # Empty config is considered valid (no sectors configured)
+        return []
+
     try:
         return [int(x) for x in config.split(",")]
     except (ValueError, AttributeError):

diff --git a/tests/test_helpers.py b/tests/test_helpers.py
@@ -11,6 +11,11 @@ def test_parse_areas_config_valid_input():
     assert parse_areas_config("") == []
 
 
+def test_parse_areas_config_valid_empty_input():
+    assert parse_areas_config("", raises=True) == []
+    assert parse_areas_config(None, raises=True) == []
+
+
 def test_parse_areas_config_invalid_input():
     assert parse_areas_config("3,a") == []
     assert parse_areas_config("3.4") == []
@@ -24,10 +29,5 @@ def test_parse_areas_config_raises_value_error():
         parse_areas_config("3.4", raises=True)
 
 
-def test_parse_areas_config_raises_attribute_error():
-    with pytest.raises(InvalidAreas):
-        parse_areas_config(None, raises=True)
-
-
 def test_parse_areas_config_whitespace():
     assert parse_areas_config(" 3 , 4 ") == [3, 4]