Skip to content

Commit

Permalink
fix grunt; fix npm run start; write to plottable.js while dev-wat…
Browse files Browse the repository at this point in the history
…ching (#3225)

* fix `grunt`; fix `npm run start`; watch writes to plottable.js

webpack-dev-server now emits the plottable.js file as it gets changed.
Unfortunately, because of gajus/write-file-webpack-plugin#35
I turned off livereloading unless you use the localhost:9999/webpack-dev-server/<filepath>
url.

* include write-file-webpack-plugin as a devDependency
  • Loading branch information
hellochar authored and CalvinFernandez committed Feb 9, 2017
1 parent cb6ed23 commit 96850e2
Show file tree
Hide file tree
Showing 4 changed files with 371 additions and 366 deletions.
2 changes: 1 addition & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ module.exports = function(grunt) {
grunt.registerTask("dist-compile", ["test", "uglify", "compress"]);

grunt.registerTask("commitjs", ["dist-compile", "gitcommit:built"]);
grunt.registerTask("default", ["npm run start"]);
grunt.registerTask("default", ["exec:npm:start"]);

grunt.registerTask("test", ["dev-compile", "test-local"]);
grunt.registerTask("test-local", ["blanket_mocha", "lint"]);
Expand Down
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@
"build:tsc": "tsc -p test/",
"build:webpack": "webpack --config webpack.config.js",
"check_version": "echo ${npm_package_version} $(npm view ${npm_package_name} version) | awk '{ if ($1 == $2) { exit 1 }}'",
"start": "npm-run-all -p watch:watch-tsc watch:watch-quicktests webpack-dev-server",
"start": "npm-run-all -p start:watch-tsc start:watch-quicktests start:webpack-dev-server",
"start:watch-quicktests": "grunt watch-quicktests",
"start:watch-tsc": "tsc -w -p test/",
"start:webpack-dev-server": "webpack-dev-server",
"test": "grunt test-travis"
},
"devDependencies": {
Expand Down Expand Up @@ -56,7 +57,8 @@
"tslint": "3.15.1",
"typescript": "2.0.6",
"webpack": "2.2.1",
"webpack-dev-server": "2.3.0"
"webpack-dev-server": "2.3.0",
"write-file-webpack-plugin": "3.4.2"
},
"dependencies": {
"d3": "^3.5.16",
Expand Down
Loading

1 comment on commit 96850e2

@blueprint-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix `grunt`; fix `npm run start`; write to plottable.js while dev-watching (#3225)

Demo: quicktests | fiddle

Please sign in to comment.