Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when symlink cannot be accessed during walk #378

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

pivotal-david-osullivan
Copy link
Contributor

Summary

The file walk used by libbs e.g. to create a listing of the source/workspace directory can fail if it encounters a directory symlink that it cannot follow - this PR improves the error relating to this situation

Use Cases

User source path contains a symlink dir/file that cannot be followed

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pivotal-david-osullivan pivotal-david-osullivan added type:enhancement A general enhancement semver:patch A change requiring a patch version bump labels Nov 18, 2024
@pivotal-david-osullivan pivotal-david-osullivan requested a review from a team as a code owner November 18, 2024 14:14
@dmikusa
Copy link
Contributor

dmikusa commented Nov 18, 2024

Thanks! I'm pretty sure I've seen that come up. This will make it a lot clearer.

@dmikusa dmikusa merged commit eec8661 into main Nov 18, 2024
8 checks passed
@dmikusa dmikusa deleted the symlink-error-polish branch November 18, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants