Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes caching by accounting for dep_date at metadata root level #309

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

pivotal-david-osullivan
Copy link
Contributor

Summary

Some buildpacks store layer metadata in a dependency field, others do not. Previously, the fix for deprecation_date handling/comparison only accounted for the first scenario. This PR handles the date being at the root level of the layer metadata map.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pivotal-david-osullivan pivotal-david-osullivan added type:bug A general bug semver:patch A change requiring a patch version bump labels Jan 24, 2024
@pivotal-david-osullivan pivotal-david-osullivan requested a review from a team as a code owner January 24, 2024 12:05
layer.go Outdated Show resolved Hide resolved
@dmikusa dmikusa merged commit a3f457a into main Feb 6, 2024
6 checks passed
@dmikusa dmikusa deleted the caching-fix branch February 6, 2024 04:54
dmikusa added a commit that referenced this pull request Nov 11, 2024
Signed-off-by: Daniel Mikusa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants