Handles deprecationDate in time.Time format in actual layer metadata #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents panic as described in issue paketo-buildpacks#269. This change makes the Equals method more robust, by not panicking when the deprecationDate is present in the layer metadata in an unexpected format.
dmikusa
added
type:bug
pivotal-david-osullivan
approved these changes
Jan 23, 2024
pivotal-david-osullivan
merged commit f1f6407
into
paketo-buildpacks:main
4 checks passed
dmikusa
added a commit
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Daniel Mikusa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevents panic as described in issue #269. After the change https://github.com/paketo-buildpacks/libpak/pull/261/files the Equals method became prone to panics due to the unchecked type assertions. This change makes the Equals method more robust, by not panicking when the deprecationDate is present in the layer metadata in an unexpected format.
Use Cases
Handling various LayerMetadata from without breaking whenever it does not exactly conform to expections.
Checklist