Revert "adds logic to remove http query params from destination file name" #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotal-david-osullivan
added
type:bug
dmikusa
approved these changes
Oct 2, 2023
pivotal-david-osullivan
deleted the
revert-273-fix/filename-remove-query-params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #273
A bug was discovered as a result of this change, wrt caching & offline buildpacks - when restoring dependencies from the cache, the dependency URI is used and not the URI SHA.
Given the potential to break apps on rebuild, this PR proposes reverting the change - it could be implemented for v2 of Libpak via #287
We will cut a new libpak and release new component buildpacks based on this - the composites have not yet been released with #273.