Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add party to kc metadata #587

Merged
merged 6 commits into from
Nov 11, 2024
Merged

feat: add party to kc metadata #587

merged 6 commits into from
Nov 11, 2024

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Nov 9, 2024

Completes the party aspect of #585

@iProdigy iProdigy marked this pull request as ready for review November 11, 2024 08:43
pajlada
pajlada approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, would like to see what's changed in the discord notifications. Haven't tested

@iProdigy
Copy link
Member Author

sample discord notif
image

@pajlada
Copy link
Member

pajlada commented Nov 11, 2024

Does this change modify the loot notifier if you're in a raid?

@iProdigy
Copy link
Member Author

shouldn't be any change to the loot notifier from this PR (that embed already has the same Party Size field)

Felanbird
Felanbird approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@Felanbird Felanbird left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for 1player party

@iProdigy iProdigy merged commit 0a30d8b into pajlads:master Nov 11, 2024
4 checks passed
@iProdigy iProdigy deleted the feature/kc-party-metadata branch November 11, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felanbird Felanbird Felanbird approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iProdigy @pajlada @Felanbird