Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rarity for npc pickpocketing #571

Merged
merged 9 commits into from
Oct 19, 2024

Conversation

iProdigy
Copy link
Member

Related to #139

Since there's no wiki parsing script yet, this PR adds the most relevant drops from pickpocketing (typically just the single rarest item on each drop table)

thieving.json was created by hand, so there is no script to produce it (yet)

@iProdigy iProdigy marked this pull request as ready for review October 15, 2024 10:33
@iProdigy iProdigy requested a review from pajlada October 17, 2024 09:34
@iProdigy iProdigy force-pushed the feature/loot-pickpocket-rarity branch from 2f16f54 to 96b5f48 Compare October 18, 2024 19:37
@iProdigy iProdigy added this to the 1.10.12 milestone Oct 18, 2024
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - have not tested in game or verified the drop rates

Copy link
Member

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test but picked out some items and they seem correct

@iProdigy iProdigy merged commit 8ae550b into pajlads:master Oct 19, 2024
4 checks passed
@iProdigy iProdigy deleted the feature/loot-pickpocket-rarity branch October 19, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants