feat: add DinkMigrate client command #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
The readme is clear & the code looks good to me. Should be a fairly simple review - builder pattern looks good for both the small & big plugins.
Just one question regarding the message after a migration, then I'm good
I have not tested this yet, which we should do somewhat thoroughly before merging this in (+ making sure maintainers have a chance to look at the issues you've created)
Felanbird
approved these changes
Oct 27, 2024
|
No objections from the other plugin authors within a (little over a) month; merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #563
PJGJ210/Discord-Collection-Logger#5 ✅
Boredska/gim-bank-discord#3
MidgetJake/UniversalDiscordNotifier#41
jamesdrudolph/Discord-Death-Notifications#11
RinZJ/better-discord-loot-logger#30
ATremonte/Discord-Level-Notifications#12 ✅
jack0lantern/raidshamer#2 ✅