Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add npc id to loot metadata #550

Merged
merged 7 commits into from
Sep 28, 2024
Merged

feat: add npc id to loot metadata #550

merged 7 commits into from
Sep 28, 2024

Conversation

iProdigy
Copy link
Member

Closes #549

@iProdigy iProdigy marked this pull request as ready for review September 22, 2024 03:24
pajlada
pajlada approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good, I just prefer the simple npc finder

src/main/java/dinkplugin/notifiers/LootNotifier.java Outdated Show resolved Hide resolved
@iProdigy iProdigy enabled auto-merge (squash) September 28, 2024 17:28
@iProdigy iProdigy merged commit d6da5bf into pajlads:master Sep 28, 2024
4 checks passed
@iProdigy iProdigy deleted the feature/loot-npc-id-metadata branch September 28, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felanbird Felanbird Felanbird approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NPC ID in loot notification
3 participants
@iProdigy @pajlada @Felanbird