Bug Fix: add includeSelector to getUserdetails api (#89)

* v2.7.7 * added include selector to user details
pajaydev · May 9, 2020 · c52bdcb · c52bdcb
1 parent c36e6b3
commit c52bdcb
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 9 deletions.
diff --git a/demo/shopping.js b/demo/shopping.js
@@ -16,7 +16,7 @@ ebay.getAllCategories('1234').then((data) => {
 
 // // Get User Profile 
 // // https://developer.ebay.com/devzone/shopping/docs/callref/GetUserProfile.html
-ebay.getUserDetails({ userId: 'ajaykumapratha_0', details: true }).then((data) => {
+ebay.getUserDetails({ userId: 'ajaykumapratha_0', includeSelector: 'Details' }).then((data) => {
     console.log(data);
 }, (error) => {
     console.log(error);

diff --git a/docs/README.md b/docs/README.md
@@ -322,7 +322,7 @@ ebay.getAllCategories('1234').then((data) => {
 Get User Profile
 ```javascript
 //https://developer.ebay.com/devzone/shopping/docs/callref/GetUserProfile.html
-ebay.getUserDetails({ userId: 'ajaykumapratha_0', details: true }).then((data) => {
+ebay.getUserDetails({ userId: 'ajaykumapratha_0', includeSelector: true }).then((data) => {
     console.log(data);
 }, (error) => {
     console.log(error);

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ebay-node-api",
-  "version": "2.8.3",
+  "version": "2.8.4",
   "description": "Ebay node api client",
   "main": "./src/index.js",
   "homepage": "https://github.com/pajaydev/ebay-node-api",

diff --git a/src/shopping.js b/src/shopping.js
@@ -6,7 +6,6 @@ const makeString = require('make-string');
 
 const getAllCategories = function (categoryID) {
     const requestURL = `${urlObject.buildShoppingUrl(this.options, 'GetCategoryInfo')}&${stringifyUrl({ 'CategoryID': categoryID || -1 })}`;
-    console.log(requestURL);
     return getRequest(requestURL).then((data) => {
         return JSON.parse(data);
     }, console.error // eslint-disable-line no-console
@@ -16,8 +15,8 @@ const getAllCategories = function (categoryID) {
 const getUserDetails = function (input) {
     if (!input || typeof input !== 'object') throw new Error('invalid_request_error -> Invalid input');
     if (!input.userId) throw new Error('invalid_request_error -> userId is null or invalid');
+    input.includeSelector = input.includeSelector ? input.includeSelector : 'Details';
     const requestUrl = `${urlObject.buildShoppingUrl(this.options, 'GetUserProfile')}&${stringifyUrl(input)}`;
-    console.log(requestUrl);
     return getRequest(requestUrl).then((data) => {
         return JSON.parse(data);
     }, console.error // eslint-disable-line no-console
@@ -30,7 +29,6 @@ const getItemStatus = function (itemIds) {
         'ItemID': makeString(itemIds, { braces: 'false', quotes: 'no' })
     };
     const requestUrl = `${urlObject.buildShoppingUrl(this.options, 'GetItemStatus')}&${stringifyUrl(paramsObj)}`;
-    console.log(requestUrl);
     return getRequest(requestUrl).then((data) => {
         return JSON.parse(data);
     }, console.error // eslint-disable-line no-console
@@ -41,7 +39,6 @@ const getShippingCosts = function (input) {
     if (!input || typeof input !== 'object') throw new Error('invalid_request_error -> Invalid input');
     if (!input.itemId) throw new Error('invalid_request_error -> Item id is null or invalid');
     const url = `${urlObject.buildShoppingUrl(this.options, 'GetShippingCosts')}&${stringifyUrl(input)} `;
-    console.log(url);
     return getRequest(url).then((data) => {
         return JSON.parse(data);
     }, console.error // eslint-disable-line no-console
@@ -56,7 +53,6 @@ const getShippingCosts = function (input) {
 const getMultipleItems = function (options) {
     if (!options || !options.itemId) throw new Error('invalid_request_error -> Item ID is null or invalid');
     const requestUrl = `${urlObject.buildShoppingUrl(this.options, 'GetMultipleItems')}&${stringifyUrl({ 'itemId': makeString(options.itemId, { braces: 'false', quotes: 'no' }) })}`;
-    console.log(requestUrl);
     return getRequest(requestUrl).then((data) => {
         return JSON.parse(data);
     }, console.error // eslint-disable-line no-console

diff --git a/test/shopping.test.js b/test/shopping.test.js
@@ -49,13 +49,25 @@ describe('test shopping api', () => {
                 clientID: 'ABCXXX123'
             });
             nock('https://api.ebay.com')
-                .get('/Shopping?appid=ABCXXX123&callname=GetUserProfile&version=967&siteid=0&responseencoding=JSON&userId=test')
+                .get('/Shopping?appid=ABCXXX123&callname=GetUserProfile&version=967&siteid=0&responseencoding=JSON&userId=test&includeSelector=Details')
                 .reply(200, { getUserDetails: true });
             ebay.getUserDetails({ userId: 'test' }).then((data) => {
                 expect(data).to.deep.equal({ getUserDetails: true });
             });
         });
 
+        it('test getUserDetails method with include selector', () => {
+            const ebay = new Ebay({
+                clientID: 'ABCXXX123'
+            });
+            nock('https://api.ebay.com')
+                .get('/Shopping?appid=ABCXXX123&callname=GetUserProfile&version=967&siteid=0&responseencoding=JSON&userId=test&includeSelector=sample')
+                .reply(200, { getUserDetailsWithIncludeSelector: true });
+            ebay.getUserDetails({ userId: 'test', includeSelector: 'sample' }).then((data) => {
+                expect(data).to.deep.equal({ getUserDetailsWithIncludeSelector: true });
+            });
+        });
+
         it('test getShippingCosts method', () => {
             const ebay = new Ebay({
                 clientID: 'ABCXXX123'