Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-288] feat: Update receipt eventData when missing on regen pdf #35

Merged
merged 1 commit into from
Dec 15, 2023
Merged

[PRDP-288] feat: Update receipt eventData when missing on regen pdf #35

merged 1 commit into from
Dec 15, 2023

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Dec 15, 2023 •
edited
Loading

List of Changes

Motivation and Context

  • Introduced receipt update on regen for eventData

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

72.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

pasqualespica
pasqualespica approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica pasqualespica merged commit e65b662 into main Dec 15, 2023
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-cialini alessio-cialini

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-cialini @pasqualespica @alexyey