Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-284] feat: introduced limits on scheduled and massive recovery #29

Merged
merged 5 commits into from
Dec 14, 2023
Merged

[PRDP-284] feat: introduced limits on scheduled and massive recovery #29

merged 5 commits into from
Dec 14, 2023

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Dec 14, 2023 •
edited
Loading

List of Changes

  • Updated wrong environment variable in scheduled function for notification recovery
  • Introduced limit on failed massive recovery (scheduled and api) using a environment variables for the number of days
  • Introduced limit on not notified massive recovery (scheduled and api) using a environment variables for the number of days

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-cialini alessio-cialini added the bug Something isn't working label Dec 14, 2023
@alessio-cialini alessio-cialini changed the title fix: wrong env variable name in notify scheduled recovery [PRDP-284] feat: introduced limits on scheduled and massive recovery Dec 14, 2023
pasqualespica
pasqualespica approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alessio-cialini
fix: wrong env variable name in notify scheduled recovery
d28d11c
@alessio-cialini
feat: introduced limit on days for scheduled and massive recovery
1cd390d
@alessio-cialini
Merge remote-tracking branch 'origin/fix-schedule-env-var-name' into …
877d3e9 
…fix-schedule-env-var-name

# Conflicts:
#	README.md
#	helm/values-dev.yaml
#	helm/values-prod.yaml
#	helm/values-uat.yaml
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/client/impl/ReceiptCosmosClientImpl.java
@github-actions GitHub Actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pasqualespica pasqualespica merged commit 09ea985 into main Dec 14, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-cialini alessio-cialini

Labels
bug Something isn't working patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio-cialini @pasqualespica