Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schedule env vars #26

Merged
merged 65 commits into from
Dec 12, 2023
Merged

Fix schedule env vars #26

merged 65 commits into from
Dec 12, 2023

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Dec 7, 2023 •
edited
Loading

List of Changes

  • Fixed scheduler env vars
  • Fixed typo on scheduled recovery for failed receipts
  • Fixed error on encoding for get receipt errors
  • Updated missing README references

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 7, 2023
View reviewed changes
src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/utils/Aes256Utils.java
SecretKeySpec secretKeySpec = new SecretKeySpec(tmp.getEncoded(), ALGORITHM);

//Padding vulnerability rule java:S5542 ignored because encryption is used inside application workflow
Cipher cipher = Cipher.getInstance(AES_CBC_PKCS_5_PADDING);

Check failure

Code scanning / SonarCloud

Encryption algorithms should be used with secure mode and padding scheme High

Use another cipher mode or disable padding. See more on SonarCloud
src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/utils/Aes256Utils.java
SecretKeySpec secretKeySpec = new SecretKeySpec(tmp.getEncoded(), ALGORITHM);

//Padding vulnerability rule java:S5542 ignored because decryption is used inside application workflow
Cipher cipher = Cipher.getInstance(AES_CBC_PKCS_5_PADDING);

Check failure

Code scanning / SonarCloud

Encryption algorithms should be used with secure mode and padding scheme High

Use another cipher mode or disable padding. See more on SonarCloud
@alessio-cialini alessio-cialini added patch and removed skip labels Dec 7, 2023
alessio-cialini and others added 20 commits December 7, 2023 16:54
@alessio-cialini
temp change to RegenerateReceiptPdf
b084042
@alessio-cialini
temp change to RegenerateReceiptPdf
1413c8d
@pagopa-github-bot
Bump to version 0.6.13-fix-schedule-env-vars [skip ci]
fb82665
@alessio-cialini
temp change to GenerateReceiptPdfServiceImpl
b9e40bc
@alessio-cialini
Merge remote-tracking branch 'origin/fix-schedule-env-vars' into fix-…
127e2b2 
…schedule-env-vars
@pagopa-github-bot
Bump to version 0.6.14-fix-schedule-env-vars [skip ci]
1c0c2c0
@alessio-cialini
temp change to GenerateReceiptPdfServiceImpl
6cdb4ca
@alessio-cialini
Merge remote-tracking branch 'origin/fix-schedule-env-vars' into fix-…
3010863 
…schedule-env-vars
@pagopa-github-bot
Bump to version 0.6.15-fix-schedule-env-vars [skip ci]
4f21ffd
@alessio-cialini
temp change to GenerateReceiptPdfServiceImpl
1c7fe55
@alessio-cialini
Merge remote-tracking branch 'origin/fix-schedule-env-vars' into fix-…
b0128aa 
…schedule-env-vars
@pagopa-github-bot
Bump to version 0.6.16-fix-schedule-env-vars [skip ci]
96db924
@alessio-cialini
temp change to GenerateReceiptPdfServiceImpl
94119a4
@alessio-cialini
Merge remote-tracking branch 'origin/fix-schedule-env-vars' into fix-…
100bc8f 
…schedule-env-vars
@alessio-cialini
temp change to GenerateReceiptPdfServiceImpl
74cec7e
@pagopa-github-bot
Bump to version 0.6.17-fix-schedule-env-vars [skip ci]
baacd12
@alessio-cialini
Reinstating proper versions
4d3b143
@alessio-cialini
Merge remote-tracking branch 'origin/fix-schedule-env-vars' into fix-…
11c40c8 
…schedule-env-vars
@pagopa-github-bot
Bump to version 0.6.18-fix-schedule-env-vars [skip ci]
c19b035
@alexyey
feat: updated receipt generation services
13a35e3
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability D 2 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

90.1% 90.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

pasqualespica
pasqualespica approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica pasqualespica merged commit 3733602 into main Dec 12, 2023
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-cialini alessio-cialini

Labels
patch size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio-cialini @pasqualespica @pagopa-github-bot @alexyey