Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPANTT-90] feat: add result event producers #5

Merged
merged 11 commits into from
Sep 24, 2024
Merged

[PPANTT-90] feat: add result event producers #5

merged 11 commits into from
Sep 24, 2024

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Sep 19, 2024 •
edited
Loading

List of Changes

  • Introduced management of events for req/res tracing, and creditorInstitution data
  • Updated unit testing

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-cialini alessio-cialini added the enhancement New feature or request label Sep 19, 2024
@alessio-cialini alessio-cialini requested a review from a team as a code owner September 19, 2024 10:08
@github-actions GitHub Actions
Copy link

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

@alessio-cialini
Merge branch 'PPANTT-80-feat-add-psp-api' into PPANTT-90-add-result-e…
4b89d44 
…vent-producers

# Conflicts:
#	.github/workflows/code_review.yml
#	.github/workflows/integration_test.yml
@alessio-cialini
Merge remote-tracking branch 'origin/main' into PPANTT-90-add-result-…
2dd7e91 
…event-producers

# Conflicts:
#	openapi/openapi.json
#	src/test/java/it/gov/pagopa/payment/options/WireMockExtensions.java
@alessio-cialini
[PPANTT-90] feat: Updated tests
14ec849
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

gioelemella
gioelemella approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@gioelemella gioelemella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed

Issues
43 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alessio-cialini alessio-cialini merged commit 2c45aa9 into main Sep 24, 2024
13 checks passed
@alessio-cialini alessio-cialini deleted the PPANTT-90-add-result-event-producers branch September 24, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioelemella gioelemella gioelemella approved these changes

@jacopocarlini jacopocarlini Awaiting requested review from jacopocarlini

@svariant svariant Awaiting requested review from svariant svariant is a code owner

Assignees

@alessio-cialini alessio-cialini

Labels
enhancement New feature or request minor size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio-cialini @gioelemella