Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated openapi.json, PaymentOptionsResource #17

Merged
merged 6 commits into from
Oct 11, 2024
Merged

feat: Updated openapi.json, PaymentOptionsResource #17

merged 6 commits into from
Oct 11, 2024

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Oct 4, 2024 •
edited by gioelemella
Loading

List of Changes

  • fix openapi error
  • update service path from payment-options/service to odp/service
  • updated error code enum
  • updated openapi

Motivation and Context

PPANTT-157

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pasqualespica
pasqualespica approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@gioelemella gioelemella merged commit bcf7309 into main Oct 11, 2024
21 of 22 checks passed
@gioelemella gioelemella deleted the fix-openapi branch October 11, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

@svariant svariant Awaiting requested review from svariant svariant is a code owner

@gioelemella gioelemella Awaiting requested review from gioelemella gioelemella is a code owner

Assignees

@alessio-cialini alessio-cialini

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio-cialini @pasqualespica @gioelemella @pagopa-github-bot