Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CHK-3339] remove unused wallet last used configurations #2488

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

scaminati-bv
Copy link
Collaborator

@scaminati-bv scaminati-bv commented Oct 16, 2024

Depends on pagopa/pagopa-ecommerce-transactions-service#584
Depends on pagopa/pagopa-payment-wallet-event-dispatcher-service#31

List of changes

  • remove unused wallet_usage_update_queue
  • remove wallet_storage_connection_string from ecommerce keyvault

Motivation and context

This configurations is not used anymore and is replaced by new last used payment method

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@scaminati-bv scaminati-bv added env: dev The status refers to DEV environment env: uat The status refers to UAT environment env: prod The status refers to PROD environment labels Oct 16, 2024
Copy link

dpulls bot commented Oct 16, 2024

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

1 similar comment
Copy link

dpulls bot commented Oct 16, 2024

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

@scaminati-bv scaminati-bv marked this pull request as ready for review October 16, 2024 10:34
@scaminati-bv scaminati-bv requested review from a team as code owners October 16, 2024 10:34
Copy link

dpulls bot commented Oct 16, 2024

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

Copy link

dpulls bot commented Oct 16, 2024

⚠️ Dpulls not installed on repository pagopa/pagopa-payment-wallet-event-dispatcher-service. Checkout our quickstart for how to install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env: dev The status refers to DEV environment env: prod The status refers to PROD environment env: uat The status refers to UAT environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants