Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): sampling and improvements for logging [PAGOPA-2178] #109

Merged

Conversation

jacopocarlini
Copy link
Contributor

@jacopocarlini jacopocarlini commented Sep 25, 2024

List of Changes

πŸ“Š kibana dashboard log format
πŸ—’οΈ remove useless log info
πŸ“ sampling on application insight

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

jacopocarlini and others added 4 commits September 25, 2024 10:02
…ttimizzazione-dei-log' into PAGOPA-2178-gpd-debito-tecnico-ottimizzazione-dei-log
@jacopocarlini jacopocarlini changed the title logging [PAGOPA-2178] chore(logging): sampling and improvements for logging Sep 26, 2024
@jacopocarlini jacopocarlini changed the title [PAGOPA-2178] chore(logging): sampling and improvements for logging chore(logging): sampling and improvements for logging [PAGOPA-2178] Sep 26, 2024
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@jacopocarlini jacopocarlini marked this pull request as ready for review September 26, 2024 15:02
@jacopocarlini jacopocarlini requested a review from a team as a code owner September 26, 2024 15:02
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
arg = "unreadable!";
}
}
if (isSensitive && arg != null) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @Sensitive for fields too

Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

Copy link

sonarcloud bot commented Sep 30, 2024

Copy link
Collaborator

@alessio-acitelli alessio-acitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ great work

@jacopocarlini jacopocarlini merged commit 1ab1440 into main Oct 4, 2024
10 of 12 checks passed
@jacopocarlini jacopocarlini deleted the PAGOPA-2178-gpd-debito-tecnico-ottimizzazione-dei-log branch October 4, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants