Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: [PagoPa-2166] - fix list info for cart #93

Merged
merged 9 commits into from
Sep 25, 2024
Merged

bug: [PagoPa-2166] - fix list info for cart #93

merged 9 commits into from
Sep 25, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

List of Changes

  • fixed id value
  • fixed payeeName e payeeTaxCode value
  • fixed amount value
  • fixed junit tests

Motivation and Context

  • error reporting by users of the service

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pasqualespica pasqualespica marked this pull request as ready for review September 24, 2024 12:11
@pasqualespica pasqualespica requested a review from a team as a code owner September 24, 2024 12:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pasqualespica
pasqualespica approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pasqualespica pasqualespica merged commit 88150f1 into main Sep 25, 2024
14 of 16 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-2166-fix-list-info-for-cart branch September 25, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
minor size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio-acitelli @pasqualespica