Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-1996] Paid Notice List: new path #87

Conversation

jacopocarlini
Copy link
Contributor

@jacopocarlini jacopocarlini commented Sep 4, 2024

List of Changes

🆕 added the new path in according to DR.
📜 openApi files updated
🥶 deprecated old path

You can check the new openapi here

Motivation and Context

Jira Task

How Has This Been Tested?

🤖 Junit
✋ Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jacopocarlini jacopocarlini requested a review from a team as a code owner September 4, 2024 16:09
@jacopocarlini jacopocarlini added enhancement New feature or request minor labels Sep 4, 2024
Copy link
Collaborator

@alessio-acitelli alessio-acitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check my comment on NoticeListItemController

…996-lap-sviluppo-modificare-lattuale-lista-transazioni-in-lista-avvisi-pagati

# Conflicts:
#	openapi/openapi.json
#	openapi/openapi_ec.json
#	openapi/openapi_helpdesk.json
#	openapi/openapi_io.json
#	src/main/java/it/gov/pagopa/bizeventsservice/controller/IPaidNoticeController.java
#	src/main/java/it/gov/pagopa/bizeventsservice/controller/impl/PaidNoticeController.java
#	src/test/java/it/gov/pagopa/bizeventsservice/controller/PaidNoticeControllerTest.java
Copy link
Collaborator

@alessio-acitelli alessio-acitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good job

Copy link

github-actions bot commented Sep 5, 2024

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

sonarcloud bot commented Sep 5, 2024

@jacopocarlini jacopocarlini merged commit 4a4f98f into main Sep 5, 2024
11 of 13 checks passed
@jacopocarlini jacopocarlini deleted the PAGOPA-1996-lap-sviluppo-modificare-lattuale-lista-transazioni-in-lista-avvisi-pagati branch September 5, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants