Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Extract isQuery param #97

Merged
merged 2 commits into from
Jul 19, 2023
Merged

fix: Extract isQuery param #97

merged 2 commits into from
Jul 19, 2023

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Jul 19, 2023

List of Changes

  • Set isQuery true when create document
  • Set isQuery false when delete document
  • Set isQuery false when get document

Motivation and Context

JSON Validation Error

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang added the bug Something isn't working label Jul 19, 2023
@cap-ang cap-ang self-assigned this Jul 19, 2023
@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@cap-ang cap-ang merged commit 41446c1 into main Jul 19, 2023
9 of 11 checks passed
@cap-ang cap-ang deleted the fix-perf-test branch July 19, 2023 13:26
@cap-ang cap-ang temporarily deployed to dev July 19, 2023 13:28 — with GitHub Actions Inactive
@cap-ang cap-ang temporarily deployed to dev July 19, 2023 13:28 — with GitHub Actions Inactive
@cap-ang cap-ang temporarily deployed to dev July 19, 2023 13:33 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants