Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAGOPA-1172 adding api definitions and openapi files #122

Conversation

FedericoRuzzier
Copy link
Contributor

List of Changes

Adding new api v2 structure and openapi for cart

Motivation and Context

This addition is needed in order to add the new functionalities of the cart

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the enhancement New feature or request label Jan 31, 2024
Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

openapi/openapi_v1.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@alessio-acitelli alessio-acitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 👍

Copy link

github-actions bot commented Feb 1, 2024

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@FedericoRuzzier FedericoRuzzier merged commit a9c3c8d into main Feb 1, 2024
8 of 10 checks passed
@FedericoRuzzier FedericoRuzzier deleted the PAGOPA-1172-sviluppo-carrello-multi-ente-definizione-interfacce-v-2 branch February 1, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants