Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PagoPA-1327]: psp whitelist #121

Merged
merged 26 commits into from
Feb 7, 2024
Merged

Conversation

alessio-acitelli
Copy link
Collaborator

@alessio-acitelli alessio-acitelli commented Jan 24, 2024

List of Changes

  • added properties for configuring a white psp list

Motivation and Context

  • No psp bundles, other than those expected, must be returned

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-acitelli alessio-acitelli marked this pull request as ready for review January 25, 2024 16:06
@@ -1,2 +1,3 @@
AFM_HOST=https://api.platform.pagopa.it/afm/calculator-service/v1
PSP_WHITELIST=PPAYITR1XXX,BPPIITRRXXX,CIPBITMM,UNCRITMM,BNLIITRR,BCITITMM,BIC36019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not but since it was already there I aligned it

Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

aacitelli added 2 commits February 7, 2024 15:11
https://github.com/pagopa/pagopa-afm-calculator into
PAGOPA-1327-psp-whitelist

Conflicts:
	helm/Chart.yaml
	helm/values-dev.yaml
	helm/values-prod.yaml
	helm/values-uat.yaml
	openapi/openapi-node.json
	openapi/openapi.json
	pom.xml
	src/test/resources/application.properties
Copy link

github-actions bot commented Feb 7, 2024

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

sonarcloud bot commented Feb 7, 2024

@alessio-acitelli alessio-acitelli merged commit d0cf43a into main Feb 7, 2024
9 of 10 checks passed
@alessio-acitelli alessio-acitelli deleted the PAGOPA-1327-psp-whitelist branch February 7, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants