Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B2BP-933] [B2BP-934] - Video-image: add title and subtitle on image rendering and add image for mobile breakpoint #475

Merged
merged 13 commits into from
Oct 17, 2024

Conversation

salvatorediocaro
Copy link
Collaborator

@salvatorediocaro salvatorediocaro commented Oct 11, 2024

List of Changes

Same as the title

Motivation and Context

Update component

How Has This Been Tested?

Run locally on localhost:6006

Screenshots :

BEFORE
before

AFTER
after

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Doesn't need any documentation update.

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: b649b95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nextjs-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (53c54ee) to head (b649b95).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   98.57%   98.58%           
=======================================
  Files          21       21           
  Lines        1197     1198    +1     
  Branches       39       39           
=======================================
+ Hits         1180     1181    +1     
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.changeset/unlucky-berries-press.md Outdated Show resolved Hide resolved
Copy link
Contributor

Branch is not up to date with base branch

@salvatorediocaro it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

@salvatorediocaro salvatorediocaro changed the title [B2BP-933] - Video-image: add title and subtitle on image rendering [B2BP-933] [B2BP-934] - Video-image: add title and subtitle on image rendering and add image for mobile breakpoint Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue B2BP-933

@simosalsi simosalsi merged commit 800b8fb into main Oct 17, 2024
13 checks passed
@simosalsi simosalsi deleted the video-image-ui-fix branch October 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants