[P2] Fix binding, etc. not being removed when switching with Baton Pass

[innerthunder]

What are the changes the user will see?

This fixes an issue where binding effects (e.g. Bind, Sand Tomb) and other volatile effects would persist after the source used Baton Pass or Shed Tail to switch out.

Why am I making these changes?

This was discussed in the Discord. I assumed this interaction was correct when implementing Shed Tail 🤷‍♂️

What are the changes from a developer perspective?

phases/switch-summon-phase: The code to remove tags from enemies with the returning Pokemon as the source no longer only runs for the SWITCH switch type.

Screenshots/Videos

How to test the changes?

npm run test baton_pass (1 new test)

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• [?] Are the changes visual?
  • [?] Have I provided screenshots/videos of the changes?

[DayKev]

Noticed a couple unrelated problems with switch-summon-phase.ts while looking over this PR lmao.

pokerogue/src/phases/switch-summon-phase.ts

Line 19 in 1ad4f3b

private readonly slotIndex: integer;

pokerogue/src/phases/switch-summon-phase.ts

Lines 48 to 49 in 1ad4f3b

	//@ts-ignore
	this.slotIndex = this.scene.currentBattle.trainer?.getNextSummonIndex(!this.fieldIndex ? TrainerSlot.TRAINER : TrainerSlot.TRAINER_PARTNER); // TODO: what would be the default trainer-slot fallback?

L48 should be removed, and L49 should have trainer? changed to trainer! (for now), and slotIndex shouldn't be marked as readonly on L19.

[Snailman11]

Fixes
#4309