Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fixes: Dark Deal reducing transformed Pokemon's held item stacks to 1 #4707

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

bjparker1226
Copy link
Contributor

Fixes #4580

What are the changes the user will see?

When a Pokémon is transformed into a legendary during the Dark Deal mystery encounter, it will now keep the correct number of all its held items.

Why am I making these changes?

Fixes a bug

What are the changes from a developer perspective?

Makes sure the stack count of each item on the removed Pokémon gets passed when the boss legendary is configured.

Screenshots/Videos

OriginalPokemonItems

NewPokemonItems1
NewPokemonItems2
Note Verizion has two stacks of Quick Claws. Prior to this change, they would have been reduced to 1.

How to test the changes?

Modified src/overrides.ts and src/data/mystery-encounters/encounters/dark-deal-encounter.ts to ensure the selected Pokémon was one with at least 2 of a held item. No automated tests were introduced.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@flx-sta
Copy link
Collaborator

flx-sta commented Oct 23, 2024

We should get a test covering that so it doesn’t break again

@Tempo-anon Tempo-anon merged commit a0baf89 into pagefaultgames:beta Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Dark Deal reduces transformed Pokemon's held item stacks to 1
5 participants