[Bug] fixes: Dark Deal reducing transformed Pokemon's held item stacks to 1 #4707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4580
What are the changes the user will see?
When a Pokémon is transformed into a legendary during the Dark Deal mystery encounter, it will now keep the correct number of all its held items.
Why am I making these changes?
Fixes a bug
What are the changes from a developer perspective?
Makes sure the stack count of each item on the removed Pokémon gets passed when the boss legendary is configured.
Screenshots/Videos
Note Verizion has two stacks of Quick Claws. Prior to this change, they would have been reduced to 1.
How to test the changes?
Modified
src/overrides.ts
andsrc/data/mystery-encounters/encounters/dark-deal-encounter.ts
to ensure the selected Pokémon was one with at least 2 of a held item. No automated tests were introduced.Checklist
beta
as my base branchnpm run test
)