Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move implementation] Fully implementing forests curse and trick or treat #4705

Closed

Conversation

PrabbyDD
Copy link
Contributor

@PrabbyDD PrabbyDD commented Oct 22, 2024

What are the changes the user will see?

Trick or treat and forests curse should now consistently properly interact with one another and with burn up/dual shock

Why am I making these changes?

fully implement the moves

What are the changes from a developer perspective?

Added a check in AddTypeAttr for cases related to these two moves

Screenshots/Videos

2024-10-22.13-41-19.mp4
2024-10-22.14-51-12.mp4

How to test the changes?

Override file, and new forests curse file

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@innerthunder
Copy link
Collaborator

Duplicate of #4682

(guess this wasn't marked on the implementations issue 😖 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants