[Balance] [QoL] Add Exclusive Moves from a Prior Evolution to Evolutions via Memory Mushroom #4681
+389
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsn34kzx
previously approved these changes
Oct 18, 2024
DayKev
previously approved these changes
Oct 18, 2024
|
do not commit yet |
innerthunder
requested changes
Oct 22, 2024
There was a problem hiding this comment.
I ran a script on pokemon-level-moves to get this list: pre-evo-exclusive-moves.txt
Missing moves atm:
- Butterfree: Harden
- Dipplin: Leafage
Butterfree already had Harden in its learnset, I did miss Dipplin though. Thank you! |
innerthunder
approved these changes
Oct 22, 2024
damocleas
approved these changes
Oct 22, 2024
DayKev
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Any Pokemon that had moves that were otherwise exclusive to a pre evolution now have those moves accessible through Memory Mushroom means (or through level for certain cases).
Why am I making these changes?
Requested by Damo and a common request in the discord, certain Pokemon such as Misdreavus or Pansage/Pansear/Panpour had their level up moveset neutered if you either:
A - Got lucky by finding an Evolution Stone and chose to evolve early on
or
B - Chose to forget a move that was exclusive from the pre evolution / Accidentally forgetting a move that was from the pre evolution.
This is mainly a QoL change for cases such as these, or for retaining cool, niche utility from any pre evolutions that the player can easily miss such as Sticky Web on certain Pokemon. There are also a few cases where a Pokemon miraculously loses a move in their 2nd stage such as Charmeleon losing access to Fire Spin, or Gothorita / Arctibax losing Psychic and Dragon Claw respectively.
What are the changes from a developer perspective?
Fixed Comments to be consistent across the board
Fixed the order of Poliwrath's moves
Addition of Moves for certain Pokemon in pokemon-level-moves.ts with comments signifying their inclusion / purpose.
POKEMON AFFECTED
Screenshots/Videos
Before
After
How to test the changes?
Overrides
Checklist
betaas my base branchnpm run test)