Merge branch 'beta' into pr/ElizaAlex/3667

.github/FUNDING.yml

@@ -0,0 +1 @@
+github: patapancakes

eslint.config.js

@@ -38,7 +38,8 @@ export default [
  "ignoreComments": false // Enforces the rule on lines containing comments
  }],
  "space-before-blocks": ["error", "always"], // Enforces a space before blocks
- "keyword-spacing": ["error", { "before": true, "after": true }] // Enforces spacing before and after keywords
+ "keyword-spacing": ["error", { "before": true, "after": true }], // Enforces spacing before and after keywords
+ "comma-spacing": ["error", { "before": false, "after": true }] // Enforces spacing after comma
  }
  }
 ]

src/@types/i18next.d.ts

@@ -1,9 +1,18 @@
 import { type enConfig } from "#app/locales/en/config.js";
+import { TOptions } from "i18next";
 
+//TODO: this needs to be type properly in the future
 // Module declared to make referencing keys in the localization files type-safe.
 declare module "i18next" {
  interface CustomTypeOptions {
  defaultNS: "menu", // needed here as well for typedoc
  resources: typeof enConfig
  }
+
+ interface TFunction {
+ (
+ key: string | string[],
+ options?: TOptions & Record<string, unknown>
+ ): string;
+ }
  }

src/battle-scene.ts

@@ -1629,7 +1629,7 @@ export default class BattleScene extends SceneBase {
 
  randomSpecies(waveIndex: integer, level: integer, fromArenaPool?: boolean, speciesFilter?: PokemonSpeciesFilter, filterAllEvolutions?: boolean): PokemonSpecies {
  if (fromArenaPool) {
- return this.arena.randomSpecies(waveIndex, level, undefined , getPartyLuckValue(this.party));
+ return this.arena.randomSpecies(waveIndex, level, undefined, getPartyLuckValue(this.party));
  }
  const filteredSpecies = speciesFilter ? [...new Set(allSpecies.filter(s => s.isCatchable()).filter(speciesFilter).map(s => {
  if (!filterAllEvolutions) {

src/battle.ts

@@ -499,7 +499,7 @@ export const classicFixedBattles: FixedBattleConfigs = {
  [112]: new FixedBattleConfig().setBattleType(BattleType.TRAINER).setSeedOffsetWave(35)
  .setGetTrainerFunc(getRandomTrainerFunc([ TrainerType.ROCKET_GRUNT, TrainerType.MAGMA_GRUNT, TrainerType.AQUA_GRUNT, TrainerType.GALACTIC_GRUNT, TrainerType.PLASMA_GRUNT, TrainerType.FLARE_GRUNT ], true)),
  [114]: new FixedBattleConfig().setBattleType(BattleType.TRAINER).setSeedOffsetWave(35)
- .setGetTrainerFunc(getRandomTrainerFunc([[ TrainerType.ARCHER, TrainerType.ARIANA, TrainerType.PROTON, TrainerType.PETREL ], [ TrainerType.TABITHA, TrainerType.COURTNEY ], [ TrainerType.MATT, TrainerType.SHELLY ], [ TrainerType.JUPITER, TrainerType.MARS, TrainerType.SATURN ], [ TrainerType.ZINZOLIN, TrainerType.ROOD ], [ TrainerType.XEROSIC, TrainerType.BRYONY ] ], true,1)),
+ .setGetTrainerFunc(getRandomTrainerFunc([[ TrainerType.ARCHER, TrainerType.ARIANA, TrainerType.PROTON, TrainerType.PETREL ], [ TrainerType.TABITHA, TrainerType.COURTNEY ], [ TrainerType.MATT, TrainerType.SHELLY ], [ TrainerType.JUPITER, TrainerType.MARS, TrainerType.SATURN ], [ TrainerType.ZINZOLIN, TrainerType.ROOD ], [ TrainerType.XEROSIC, TrainerType.BRYONY ] ], true, 1)),
  [115]: new FixedBattleConfig().setBattleType(BattleType.TRAINER).setSeedOffsetWave(35)
  .setGetTrainerFunc(getRandomTrainerFunc([ TrainerType.ROCKET_BOSS_GIOVANNI_1, TrainerType.MAXIE, TrainerType.ARCHIE, TrainerType.CYRUS, TrainerType.GHETSIS, TrainerType.LYSANDRE ])),
  [145]: new FixedBattleConfig().setBattleType(BattleType.TRAINER)

src/data/ability.ts

@@ -2551,7 +2551,7 @@ export class ConfusionOnStatusEffectAbAttr extends PostAttackAbAttr {
  if (simulated) {
  return defender.canAddTag(BattlerTagType.CONFUSED);
  } else {
- return defender.addTag(BattlerTagType.CONFUSED, pokemon.randSeedInt(3,2), move.id, defender.id);
+ return defender.addTag(BattlerTagType.CONFUSED, pokemon.randSeedInt(3, 2), move.id, defender.id);
  }
  }
  return false;
@@ -2733,7 +2733,7 @@ export class ConditionalCritAbAttr extends AbAttr {
  apply(pokemon: Pokemon, passive: boolean, simulated: boolean, cancelled: Utils.BooleanHolder, args: any[]): boolean {
  const target = (args[1] as Pokemon);
  const move = (args[2] as Move);
- if (!this.condition(pokemon,target,move)) {
+ if (!this.condition(pokemon, target, move)) {
  return false;
  }
 
@@ -3299,11 +3299,25 @@ export class PostTurnLootAbAttr extends PostTurnAbAttr {
  }
 }
 
+/**
+ * Attribute used for {@linkcode Abilities.MOODY}
+ */
 export class MoodyAbAttr extends PostTurnAbAttr {
  constructor() {
  super(true);
  }
-
+ /**
+ * Randomly increases one BattleStat by 2 stages and decreases a different BattleStat by 1 stage
+ * @param {Pokemon} pokemon Pokemon that has this ability
+ * @param passive N/A
+ * @param simulated true if applying in a simulated call.
+ * @param args N/A
+ * @returns true
+ *
+ * Any BattleStats at +6 or -6 are excluded from being increased or decreased, respectively
+ * If the pokemon already has all BattleStats raised to stage 6, it will only decrease one BattleStat by 1 stage
+ * If the pokemon already has all BattleStats lowered to stage -6, it will only increase one BattleStat by 2 stages
+ */
  applyPostTurn(pokemon: Pokemon, passive: boolean, simulated: boolean, args: any[]): boolean {
  const selectableStats = [BattleStat.ATK, BattleStat.DEF, BattleStat.SPATK, BattleStat.SPDEF, BattleStat.SPD];
  const increaseStatArray = selectableStats.filter(s => pokemon.summonData.battleStats[s] < 6);
@@ -3315,7 +3329,7 @@ export class MoodyAbAttr extends PostTurnAbAttr {
  pokemon.scene.unshiftPhase(new StatChangePhase(pokemon.scene, pokemon.getBattlerIndex(), true, [increaseStat], 2));
  }
  if (!simulated && decreaseStatArray.length > 0) {
- const decreaseStat = selectableStats[Utils.randInt(selectableStats.length)];
+ const decreaseStat = decreaseStatArray[Utils.randInt(decreaseStatArray.length)];
  pokemon.scene.unshiftPhase(new StatChangePhase(pokemon.scene, pokemon.getBattlerIndex(), true, [decreaseStat], -1));
  }
  return true;
@@ -4876,7 +4890,7 @@ export function initAbilities() {
  .attr(BonusCritAbAttr)
  .partial(),
  new Ability(Abilities.AFTERMATH, 4)
- .attr(PostFaintContactDamageAbAttr,4)
+ .attr(PostFaintContactDamageAbAttr, 4)
  .bypassFaint(),
  new Ability(Abilities.ANTICIPATION, 4)
  .conditionalAttr(getAnticipationCondition(), PostSummonMessageAbAttr, (pokemon: Pokemon) => i18next.t("abilityTriggers:postSummonAnticipation", { pokemonNameWithAffix: getPokemonNameWithAffix(pokemon) })),
@@ -4889,7 +4903,7 @@ export function initAbilities() {
  //@ts-ignore
  .attr(DamageBoostAbAttr, 2, (user, target, move) => target.getAttackTypeEffectiveness(move.type, user) <= 0.5), // TODO: fix TS issues
  new Ability(Abilities.FILTER, 4)
- .attr(ReceivedMoveDamageMultiplierAbAttr,(target, user, move) => target.getAttackTypeEffectiveness(move.type, user) >= 2, 0.75)
+ .attr(ReceivedMoveDamageMultiplierAbAttr, (target, user, move) => target.getAttackTypeEffectiveness(move.type, user) >= 2, 0.75)
  .ignorable(),
  new Ability(Abilities.SLOW_START, 4)
  .attr(PostSummonAddBattlerTagAbAttr, BattlerTagType.SLOW_START, 5),
@@ -4905,7 +4919,7 @@ export function initAbilities() {
  .attr(PostWeatherLapseHealAbAttr, 1, WeatherType.HAIL, WeatherType.SNOW)
  .partial(), // Healing not blocked by Heal Block
  new Ability(Abilities.SOLID_ROCK, 4)
- .attr(ReceivedMoveDamageMultiplierAbAttr,(target, user, move) => target.getAttackTypeEffectiveness(move.type, user) >= 2, 0.75)
+ .attr(ReceivedMoveDamageMultiplierAbAttr, (target, user, move) => target.getAttackTypeEffectiveness(move.type, user) >= 2, 0.75)
  .ignorable(),
  new Ability(Abilities.SNOW_WARNING, 4)
  .attr(PostSummonWeatherChangeAbAttr, WeatherType.SNOW)
@@ -4966,7 +4980,7 @@ export function initAbilities() {
  .attr(WeightMultiplierAbAttr, 0.5)
  .ignorable(),
  new Ability(Abilities.MULTISCALE, 5)
- .attr(ReceivedMoveDamageMultiplierAbAttr,(target, user, move) => target.isFullHp(), 0.5)
+ .attr(ReceivedMoveDamageMultiplierAbAttr, (target, user, move) => target.isFullHp(), 0.5)
  .ignorable(),
  new Ability(Abilities.TOXIC_BOOST, 5)
  .attr(MovePowerBoostAbAttr, (user, target, move) => move.category === MoveCategory.PHYSICAL && (user?.status?.effect === StatusEffect.POISON || user?.status?.effect === StatusEffect.TOXIC), 1.5),
@@ -5303,9 +5317,9 @@ export function initAbilities() {
  new Ability(Abilities.FULL_METAL_BODY, 7)
  .attr(ProtectStatAbAttr),
  new Ability(Abilities.SHADOW_SHIELD, 7)
- .attr(ReceivedMoveDamageMultiplierAbAttr,(target, user, move) => target.isFullHp(), 0.5),
+ .attr(ReceivedMoveDamageMultiplierAbAttr, (target, user, move) => target.isFullHp(), 0.5),
  new Ability(Abilities.PRISM_ARMOR, 7)
- .attr(ReceivedMoveDamageMultiplierAbAttr,(target, user, move) => target.getAttackTypeEffectiveness(move.type, user) >= 2, 0.75),
+ .attr(ReceivedMoveDamageMultiplierAbAttr, (target, user, move) => target.getAttackTypeEffectiveness(move.type, user) >= 2, 0.75),
  new Ability(Abilities.NEUROFORCE, 7)
  //@ts-ignore
  .attr(MovePowerBoostAbAttr, (user, target, move) => target.getAttackTypeEffectiveness(move.type, user) >= 2, 1.25), // TODO: fix TS issues
@@ -5603,6 +5617,6 @@ export function initAbilities() {
  new Ability(Abilities.POISON_PUPPETEER, 9)
  .attr(UncopiableAbilityAbAttr)
  .attr(UnswappableAbilityAbAttr)
- .conditionalAttr(pokemon => pokemon.species.speciesId===Species.PECHARUNT,ConfusionOnStatusEffectAbAttr,StatusEffect.POISON,StatusEffect.TOXIC)
+ .conditionalAttr(pokemon => pokemon.species.speciesId===Species.PECHARUNT, ConfusionOnStatusEffectAbAttr, StatusEffect.POISON, StatusEffect.TOXIC)
  );
 }

src/data/challenge.ts

@@ -439,13 +439,13 @@ export class SingleGenerationChallenge extends Challenge {
  let trainerTypes: TrainerType[] = [];
  switch (waveIndex) {
  case 182:
- trainerTypes = [ TrainerType.LORELEI, TrainerType.WILL, TrainerType.SIDNEY, TrainerType.AARON, TrainerType.SHAUNTAL, TrainerType.MALVA, Utils.randSeedItem([ TrainerType.HALA, TrainerType.MOLAYNE ]),TrainerType.MARNIE_ELITE, TrainerType.RIKA ];
+ trainerTypes = [ TrainerType.LORELEI, TrainerType.WILL, TrainerType.SIDNEY, TrainerType.AARON, TrainerType.SHAUNTAL, TrainerType.MALVA, Utils.randSeedItem([ TrainerType.HALA, TrainerType.MOLAYNE ]), TrainerType.MARNIE_ELITE, TrainerType.RIKA ];
  break;
  case 184:
  trainerTypes = [ TrainerType.BRUNO, TrainerType.KOGA, TrainerType.PHOEBE, TrainerType.BERTHA, TrainerType.MARSHAL, TrainerType.SIEBOLD, TrainerType.OLIVIA, TrainerType.NESSA_ELITE, TrainerType.POPPY ];
  break;
  case 186:
- trainerTypes = [ TrainerType.AGATHA, TrainerType.BRUNO, TrainerType.GLACIA, TrainerType.FLINT, TrainerType.GRIMSLEY, TrainerType.WIKSTROM, TrainerType.ACEROLA, Utils.randSeedItem([TrainerType.BEA_ELITE,TrainerType.ALLISTER_ELITE]), TrainerType.LARRY_ELITE ];
+ trainerTypes = [ TrainerType.AGATHA, TrainerType.BRUNO, TrainerType.GLACIA, TrainerType.FLINT, TrainerType.GRIMSLEY, TrainerType.WIKSTROM, TrainerType.ACEROLA, Utils.randSeedItem([TrainerType.BEA_ELITE, TrainerType.ALLISTER_ELITE]), TrainerType.LARRY_ELITE ];
  break;
  case 188:
  trainerTypes = [ TrainerType.LANCE, TrainerType.KAREN, TrainerType.DRAKE, TrainerType.LUCIAN, TrainerType.CAITLIN, TrainerType.DRASNA, TrainerType.KAHILI, TrainerType.RAIHAN_ELITE, TrainerType.HASSEL ];

src/data/move.ts

@@ -4437,7 +4437,7 @@ export class AddBattlerTagAttr extends MoveEffectAttr {
  }
 
  getTargetBenefitScore(user: Pokemon, target: Pokemon, move: Move): integer {
- let moveChance = this.getMoveChance(user,target,move,this.selfTarget, false);
+ let moveChance = this.getMoveChance(user, target, move, this.selfTarget, false);
  if (moveChance < 0) {
  moveChance = 100;
  }
@@ -4785,7 +4785,7 @@ export class AddArenaTrapTagHitAttr extends AddArenaTagAttr {
  * @param move {@linkcode Move} being used
  */
  apply(user: Pokemon, target: Pokemon, move: Move, args: any[]): boolean {
- const moveChance = this.getMoveChance(user,target,move,this.selfTarget, true);
+ const moveChance = this.getMoveChance(user, target, move, this.selfTarget, true);
  const side = (this.selfSideTarget ? user : target).isPlayer() ? ArenaTagSide.PLAYER : ArenaTagSide.ENEMY;
  const tag = user.scene.arena.getTagOnSide(this.tagType, side) as ArenaTrapTag;
  if ((moveChance < 0 || moveChance === 100 || user.randSeedInt(100) < moveChance) && user.getLastXMoves(1)[0].result === MoveResult.SUCCESS) {
@@ -4905,7 +4905,7 @@ export class SwapArenaTagsAttr extends MoveEffectAttr {
  }
 
 
- user.scene.queueMessage( i18next.t("moveTriggers:swapArenaTags", {pokemonName: getPokemonNameWithAffix(user)}));
+ user.scene.queueMessage(i18next.t("moveTriggers:swapArenaTags", {pokemonName: getPokemonNameWithAffix(user)}));
  return true;
  }
 }
@@ -4946,14 +4946,14 @@ export class RevivalBlessingAttr extends MoveEffectAttr {
  const slotIndex = user.scene.getEnemyParty().findIndex(p => pokemon.id === p.id);
  pokemon.resetStatus();
  pokemon.heal(Math.min(Utils.toDmgValue(0.5 * pokemon.getMaxHp()), pokemon.getMaxHp()));
- user.scene.queueMessage(`${getPokemonNameWithAffix(pokemon)} was revived!`,0,true);
+ user.scene.queueMessage(i18next.t("moveTriggers:revivalBlessing", {pokemonName: getPokemonNameWithAffix(pokemon)}), 0, true);
 
  if (user.scene.currentBattle.double && user.scene.getEnemyParty().length > 1) {
  const allyPokemon = user.getAlly();
  if (slotIndex<=1) {
  user.scene.unshiftPhase(new SwitchSummonPhase(user.scene, pokemon.getFieldIndex(), slotIndex, false, false, false));
  } else if (allyPokemon.isFainted()) {
- user.scene.unshiftPhase(new SwitchSummonPhase(user.scene, allyPokemon.getFieldIndex(), slotIndex, false, false,false));
+ user.scene.unshiftPhase(new SwitchSummonPhase(user.scene, allyPokemon.getFieldIndex(), slotIndex, false, false, false));
  }
  }
  resolve(true);
@@ -7834,9 +7834,9 @@ export function initMoves() {
  .condition((user, target, move) => user.battleData.berriesEaten.length > 0),
  new StatusMove(Moves.ROTOTILLER, Type.GROUND, -1, 10, -1, 0, 6)
  .target(MoveTarget.ALL)
- .condition((user,target,move) => {
+ .condition((user, target, move) => {
  // If any fielded pokémon is grass-type and grounded.
- return [...user.scene.getEnemyParty(),...user.scene.getParty()].some((poke) => poke.isOfType(Type.GRASS) && poke.isGrounded());
+ return [...user.scene.getEnemyParty(), ...user.scene.getParty()].some((poke) => poke.isOfType(Type.GRASS) && poke.isGrounded());
  })
  .attr(StatChangeAttr, [BattleStat.ATK, BattleStat.SPATK], 1, false, (user, target, move) => target.isOfType(Type.GRASS) && target.isGrounded()),
  new StatusMove(Moves.STICKY_WEB, Type.BUG, -1, 20, -1, 0, 6)
@@ -8586,7 +8586,7 @@ export function initMoves() {
  .condition(failIfDampCondition)
  .makesContact(false),
  new AttackMove(Moves.GRASSY_GLIDE, Type.GRASS, MoveCategory.PHYSICAL, 55, 100, 20, -1, 0, 8)
- .attr(IncrementMovePriorityAttr,(user,target,move) =>user.scene.arena.getTerrainType()===TerrainType.GRASSY&&user.isGrounded()),
+ .attr(IncrementMovePriorityAttr, (user, target, move) =>user.scene.arena.getTerrainType()===TerrainType.GRASSY&&user.isGrounded()),
  new AttackMove(Moves.RISING_VOLTAGE, Type.ELECTRIC, MoveCategory.SPECIAL, 70, 100, 20, -1, 0, 8)
  .attr(MovePowerMultiplierAttr, (user, target, move) => user.scene.arena.getTerrainType() === TerrainType.ELECTRIC && target.isGrounded() ? 2 : 1),
  new AttackMove(Moves.TERRAIN_PULSE, Type.NORMAL, MoveCategory.SPECIAL, 50, 100, 10, -1, 0, 8)

src/data/pokemon-species.ts

@@ -3,7 +3,7 @@ import BattleScene, { AnySound } from "../battle-scene";
 import { Variant, variantColorCache } from "./variant";
 import { variantData } from "./variant";
 import { GrowthRate } from "./exp";
-import { EvolutionLevel,SpeciesWildEvolutionDelay, pokemonEvolutions, pokemonPrevolutions } from "./pokemon-evolutions";
+import { EvolutionLevel, SpeciesWildEvolutionDelay, pokemonEvolutions, pokemonPrevolutions } from "./pokemon-evolutions";
 import { Type } from "./type";
 import { LevelMoves, pokemonFormLevelMoves, pokemonFormLevelMoves as pokemonSpeciesFormLevelMoves, pokemonSpeciesLevelMoves } from "./pokemon-level-moves";
 import { uncatchableSpecies } from "./biomes";
@@ -2581,7 +2581,7 @@ export function initSpecies() {
  ),
  new PokemonSpecies(Species.WALKING_WAKE, 9, false, false, false, "Paradox Pokémon", Type.WATER, Type.DRAGON, 3.5, 280, Abilities.PROTOSYNTHESIS, Abilities.NONE, Abilities.NONE, 590, 99, 83, 91, 125, 83, 109, 5, 0, 295, GrowthRate.SLOW, null, false),
  new PokemonSpecies(Species.IRON_LEAVES, 9, false, false, false, "Paradox Pokémon", Type.GRASS, Type.PSYCHIC, 1.5, 125, Abilities.QUARK_DRIVE, Abilities.NONE, Abilities.NONE, 590, 90, 130, 88, 70, 108, 104, 5, 0, 295, GrowthRate.SLOW, null, false),
- new PokemonSpecies(Species.DIPPLIN, 9, false, false, false, "Candy Apple Pokémon", Type.GRASS, Type.DRAGON, 0.4, 9.7, Abilities.SUPERSWEET_SYRUP, Abilities.GLUTTONY, Abilities.STICKY_HOLD, 485, 80, 80, 110, 95, 80, 40, 45, 50, 170, GrowthRate.ERRATIC, null, false),
+ new PokemonSpecies(Species.DIPPLIN, 9, false, false, false, "Candy Apple Pokémon", Type.GRASS, Type.DRAGON, 0.4, 9.7, Abilities.SUPERSWEET_SYRUP, Abilities.GLUTTONY, Abilities.STICKY_HOLD, 485, 80, 80, 110, 95, 80, 40, 45, 50, 170, GrowthRate.ERRATIC, 50, false),
  new PokemonSpecies(Species.POLTCHAGEIST, 9, false, false, false, "Matcha Pokémon", Type.GRASS, Type.GHOST, 0.1, 1.1, Abilities.HOSPITALITY, Abilities.NONE, Abilities.HEATPROOF, 308, 40, 45, 45, 74, 54, 50, 120, 50, 62, GrowthRate.SLOW, null, false, false,
  new PokemonForm("Counterfeit Form", "counterfeit", Type.GRASS, Type.GHOST, 0.1, 1.1, Abilities.HOSPITALITY, Abilities.NONE, Abilities.HEATPROOF, 308, 40, 45, 45, 74, 54, 50, 120, 50, 62, false, null, true),
  new PokemonForm("Artisan Form", "artisan", Type.GRASS, Type.GHOST, 0.1, 1.1, Abilities.HOSPITALITY, Abilities.NONE, Abilities.HEATPROOF, 308, 40, 45, 45, 74, 54, 50, 120, 50, 62, false, null, true),