Update Webgains transaction status

[lemonCMS]

Update transaction status to be only confirmed when payment status is cleared (or payed?).

New transactions were getting confirmed right away while they are still within their cancellation period.

[PaoloNardini]

Sorry, we can't approve this change, as this break compatibility.
The function must return the original Webgains transactions status to the upper levels without any change. The caller, by reading both the 'status' and 'paid' values can decide whether to consider the transaction confirmed or pending. In our current use, we consider "confirmed" also a transactions without payment. Thank you.

[lemonCMS]

The problem is, that payed represents if the lead is paid to the publisher. You don't receive the cleared status as you can see in the code en therefore i can never check if a lead is "cleared" without being payed to me, that is irrelevant. So line 252 should not change, but you need to consider paymentStatus: cleared for confirmed leads that are not paid yet.

[slawn]

I agree with lemonCMS here - there needs to be some better way of achieving this. The original code was based only on the paymentStatus - and I think made more sense. I use around 12 networks and not a single one gives me status confirmed the next day after the purchase - and this one does. Usually confirmed means that it cannot be cancelled anymore - and in this case user can still return an item. Put it this way, once the transaction is confirmed it should never be able to change the status to declined (at least that is the case with other networks).

I fully understand if you do not agree and have your reasons to have it this way - but maybe you would be open to do this as an option that can be configured - I could leave your code by default and bring back the old method based on paymentStatus as an option?

Thanks.