-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added v3 http interaction examples #773
chore: added v3 http interaction examples #773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There's a few minor things I think should be changed to make sure that the examples serve as a good learning tool for people who are otherwise unfamiliar with Pact.
There is also a bit of a change in the provider testing which I think is needed. While Pact performs the necessary verifications on the server's communications, it would be good to show how the test can be used to verify that side-effects have (or have not) taken place within the provider's internal logic.
Let me know what you think, and if you have any questions, let me know!
1bd679c
to
2b835ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
Just cleaned up a few little things, mostly around the docs and typing 👍
2b835ec
to
f07de75
Compare
Also rename the files to ensure they mirror the v2 examples more closely. Signed-off-by: JP-Ellis <[email protected]>
f07de75
to
a05dc0a
Compare
There's an upstream with CFFI on Windows: Will do a force merge later today as all the other tests are fine. |
📝 Summary
This PR has example usage of Pact-python version 3 HTTP interaction
🚨 Breaking Changes
🔥 Motivation
🔨 Test Plan
🔗 Related issues/PRs