Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace Slim Framework by Framework X #673

Merged

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Oct 1, 2024

Try to fix these issues:

Slim Framework + PHP Built-in web server -> slow

The web server runs only one single-threaded process, so PHP applications will stall if a request is blocked.

Framework X + ReactPHP -> faster 2x -> 4x

Supports async and non-blocking execution for maximum performance

Another option is AMPHP, but it's a bit slower, and the syntax is not similar to Slim Framework than Framework X

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11120311314

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.884%

Totals Coverage Status
Change from base Build 11118184962: 0.0%
Covered Lines: 2586
Relevant Lines: 2697

💛 - Coveralls

@tienvx
Copy link
Contributor Author

tienvx commented Oct 1, 2024

Tested with:

  • Re-run compatibility suite v3 10 times
  • Re-run examples on Windows 10 times
  • Re-run examples on MacOS 13 5 times
  • Re-run examples on MacOS 14 5 times

@tienvx tienvx requested review from JP-Ellis and YOU54F October 1, 2024 10:05
@tienvx tienvx merged commit eec2817 into pact-foundation:master Oct 1, 2024
18 checks passed
@tienvx tienvx deleted the replace-slim-framework-by-framework-x branch October 1, 2024 10:27
@tienvx
Copy link
Contributor Author

tienvx commented Oct 2, 2024

Indirectly related to #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants