Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Wrap ffi call > set interaction attributes methods #652

Merged
merged 1 commit into from
Sep 26, 2024
Merged

refactor: Wrap ffi call > set interaction attributes methods #652

merged 1 commit into from
Sep 26, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Sep 26, 2024

Related to #644

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11048456664

Details

  • 25 of 30 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 96.97%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/PhpPact/Consumer/Driver/Interaction/AbstractDriver.php 5 6 83.33%
src/PhpPact/FFI/Client.php 20 24 83.33%
Totals Coverage Status
Change from base Build 11046430539: -0.2%
Covered Lines: 2368
Relevant Lines: 2442
💛 - Coveralls

@tienvx tienvx merged commit c0e0cf9 into pact-foundation:master Sep 26, 2024
18 checks passed
@tienvx tienvx deleted the wrap-ffi-call-interaction-attributes branch September 26, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YOU54F YOU54F YOU54F approved these changes

@JP-Ellis JP-Ellis Awaiting requested review from JP-Ellis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @YOU54F