Merge pull request #461 from pact-foundation/fix/sync_message_metadata

fix: ensure sync messages write metadata to both req & res

internal/native/message_server.go

@@ -166,6 +166,32 @@ func (m *Message) WithMetadata(valueOrMatcher map[string]string) *Message {
 
 	return m
 }
+func (m *Message) WithRequestMetadata(valueOrMatcher map[string]string) *Message {
+	for k, v := range valueOrMatcher {
+		cName := C.CString(k)
+		cValue := C.CString(v)
+
+		C.pactffi_with_metadata(m.handle, cName, cValue, 0)
+
+		free(cValue)
+		free(cName)
+	}
+
+	return m
+}
+func (m *Message) WithResponseMetadata(valueOrMatcher map[string]string) *Message {
+	for k, v := range valueOrMatcher {
+		cName := C.CString(k)
+		cValue := C.CString(v)
+
+		C.pactffi_with_metadata(m.handle, cName, cValue, 1)
+
+		free(cValue)
+		free(cName)
+	}
+
+	return m
+}
 
 func (m *Message) WithRequestBinaryContents(body []byte) *Message {
 	cHeader := C.CString("application/octet-stream")

message/v4/synchronous_message.go

@@ -115,7 +115,7 @@ type SynchronousMessageWithRequestBuilder struct {
 // to go with the content
 // func (m *Message) WithMetadata(metadata MapMatcher) *Message {
 func (m *SynchronousMessageWithRequestBuilder) WithMetadata(metadata map[string]string) *SynchronousMessageWithRequestBuilder {
-	m.messageHandle.WithMetadata(metadata)
+	m.messageHandle.WithRequestMetadata(metadata)
 
 	return m
 }
@@ -164,7 +164,7 @@ type SynchronousMessageWithResponseBuilder struct {
 // to go with the content
 // func (m *Message) WithMetadata(metadata MapMatcher) *Message {
 func (m *SynchronousMessageWithResponseBuilder) WithMetadata(metadata map[string]string) *SynchronousMessageWithResponseBuilder {
-	m.messageHandle.WithMetadata(metadata)
+	m.messageHandle.WithResponseMetadata(metadata)
 
 	return m
 }

message/v4/synchronous_message_test.go

@@ -15,18 +15,17 @@ func TestSyncTypeSystem_NoPlugin(t *testing.T) {
 	p, _ := NewSynchronousPact(Config{
 		Consumer: "consumer",
 		Provider: "provider",
-		PactDir:  "/tmp/",
 	})
 	// Sync - no plugin
 	err := p.AddSynchronousMessage("some description").
 		Given("some state").
 		WithRequest(func(r *SynchronousMessageWithRequestBuilder) {
 			r.WithJSONContent(map[string]string{"foo": "bar"})
-			r.WithMetadata(map[string]string{})
+			r.WithMetadata(map[string]string{"meta_request": "meta_request_data"})
 		}).
 		WithResponse(func(r *SynchronousMessageWithResponseBuilder) {
 			r.WithJSONContent(map[string]string{"foo": "bar"})
-			r.WithMetadata(map[string]string{})
+			r.WithMetadata(map[string]string{"meta_response": "meta_response_data"})
 		}).
 		ExecuteTest(t, func(m SynchronousMessage) error {
 			// In this scenario, we have no real transport, so we need to mock/handle both directions