Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override props #117

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented Apr 13, 2023

Allow consumers to override component's props. Some examples where it can be useful:

  • Provide a custom aria-label to Command.Loading
  • Although this is not the main use case of this lib, makes possible to override aria-expanded on Command.Input to build an accessible combobox where the list opens when the focus is on the input or after typing.

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 11:31am

cmdk/src/index.tsx Outdated Show resolved Hide resolved
@joaom00 joaom00 changed the title chore: allow override props Allow override props Apr 13, 2023
@tonyfarney
Copy link

This modification would allow us to workaround accessibility issues the library has. For example: #179

Please merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants