Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code #2532

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove deprecated code #2532

wants to merge 4 commits into from

Conversation

majamassarini
Copy link
Member

@majamassarini majamassarini commented Sep 17, 2024 •
edited
Loading

Marge before packit/packit#2412

@majamassarini majamassarini requested a review from a team as a code owner September 17, 2024 12:34
@majamassarini majamassarini changed the title Remove-deprecated-code Remove deprecated code Sep 17, 2024
@majamassarini majamassarini marked this pull request as draft September 17, 2024 12:35
@majamassarini majamassarini mentioned this pull request Sep 17, 2024
Open
3 tasks
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/60ec50872bd946ea9d1b0d84b247e2b1

✔️ pre-commit SUCCESS in 2m 20s
❌ packit-service-tests FAILURE in 2m 43s

@majamassarini majamassarini force-pushed the remove-deprecated-code branch 2 times, most recently from 72c530e to 40c0c39 Compare September 17, 2024 13:11
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/50fd45f97cf84766aa19130bf0d00615

✔️ pre-commit SUCCESS in 2m 17s
✔️ packit-service-tests SUCCESS in 2m 37s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/872315633f2b4027bd4f48802cecb26a

✔️ pre-commit SUCCESS in 2m 16s
✔️ packit-service-tests SUCCESS in 2m 40s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2875ce017a9046828e5f95e77dc71bfb

❌ pre-commit NODE_FAILURE Node request 200-0007582204 failed in 0s
❌ packit-service-tests NODE_FAILURE Node request 200-0007582205 failed in 0s

@majamassarini
Copy link
Member Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/39fcb4eb3c264eeeacb4cceabceeb7d5

✔️ pre-commit SUCCESS in 2m 13s
✔️ packit-service-tests SUCCESS in 2m 34s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4614b7917d344f99bfcb55f86ec0803b

✔️ pre-commit SUCCESS in 2m 10s
✔️ packit-service-tests SUCCESS in 2m 37s

@majamassarini majamassarini marked this pull request as ready for review September 25, 2024 12:04
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/63ade96b3a9e4628abfbc00e7fa09edc

✔️ pre-commit SUCCESS in 2m 12s
✔️ packit-service-tests SUCCESS in 2m 37s

mfocko
mfocko approved these changes Oct 1, 2024
View reviewed changes
tests/unit/test_jobs.py
trigger=JobConfigTriggerType.pull_request,
packages={"package": CommonPackageConfig()},
),
],
{KojiBuildHandler},
id="config=production_build_for_pr&pull_request&MergeRequestGitlabEvent",
id="config=upstream_koji_build_for_pr&pull_request&MergeRequestGitlabEvent",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how many duplicit tests we have now :D

@majamassarini majamassarini force-pushed the remove-deprecated-code branch from 72fb227 to f8a993c Compare December 3, 2024 13:19
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/28920899a22a45efb9edd902d191c039

❌ pre-commit FAILURE in 2m 09s
✔️ packit-service-tests SUCCESS in 2m 41s

@majamassarini
Remove sync_default_files from method signatures
27463f2 
synced_files has been removed.
files_to_sync is always initialized with the default files path.
If default files have not to be synchronized then they have to be removed from files_to_sync list.
@majamassarini majamassarini force-pushed the remove-deprecated-code branch from f8a993c to 27463f2 Compare December 3, 2024 13:32
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/9af57579c6db42dbb582cf6e5b756882

✔️ pre-commit SUCCESS in 2m 09s
✔️ packit-service-tests SUCCESS in 2m 37s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

@mfocko mfocko mfocko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majamassarini @mfocko @lbarcziova