Warnings in unit tests

pachterlab · Jul 14, 2023 · 09578e3 · 09578e3
1 parent ab26222
commit 09578e3
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 7,010 deletions.
diff --git a/R/plot.R b/R/plot.R
@@ -150,7 +150,7 @@ getDivergeRange <- function(values, diverge_center = 0) {
 .dark_theme <- function() {
  # From Seurat but no axes
  black.background <- element_rect(fill = 'black')
- black.background.no.border <- element_rect(fill = 'black', size = 0)
+ black.background.no.border <- element_rect(fill = 'black', linewidth = 0)
  font.margin <- 4
  white.text <- element_text(
  colour = 'white',

diff --git a/tests/testthat/_snaps/plot/coldata-bin2d-for-multiple-samples.svg b/tests/testthat/_snaps/plot/coldata-bin2d-for-multiple-samples.svg
diff --git a/tests/testthat/_snaps/plot/coldata-bin2d-with-hexbin.svg b/tests/testthat/_snaps/plot/coldata-bin2d-with-hexbin.svg
diff --git a/tests/testthat/_snaps/plot/coldata-bin2d.svg b/tests/testthat/_snaps/plot/coldata-bin2d.svg
diff --git a/tests/testthat/_snaps/plot/rowdata-bin2d-with-subset-and-default-legend.svg b/tests/testthat/_snaps/plot/rowdata-bin2d-with-subset-and-default-legend.svg
diff --git a/tests/testthat/_snaps/plot/rowdata-bin2d-with-subset.svg b/tests/testthat/_snaps/plot/rowdata-bin2d-with-subset.svg
diff --git a/tests/testthat/_snaps/plot/rowdata-bin2d.svg b/tests/testthat/_snaps/plot/rowdata-bin2d.svg
diff --git a/tests/testthat/test-plot.R b/tests/testthat/test-plot.R
@@ -557,34 +557,6 @@ sfe_cosmx2 <- SpatialFeatureExperiment::cbind(sfe_cosmx2a, sfe_cosmx2b)
 sfe_cosmx2 <- removeEmptySpace(sfe_cosmx2)
 
 test_that("colData and rowData bin2d", {
- expect_doppelganger("colData bin2d", {
- plotColDataBin2D(sfe_cosmx, "nCounts", "nGenes")
- })
- expect_doppelganger("colData bin2d with hexbin", {
- plotColDataBin2D(sfe_cosmx, "nCounts", "nGenes", hex = TRUE)
- })
- expect_doppelganger("rowData bin2d", {
- plotRowDataBin2D(sfe_cosmx, "means", "vars", bins = 50) +
- scale_x_log10() + scale_y_log10()
- })
- expect_doppelganger("rowData bin2d with subset", {
- plotRowDataBin2D(sfe_cosmx, "means", "vars", subset = "is_neg",
- name_true = "Counts (negative controls)",
- name_false = "Counts (real genes)", bins = 50) +
- scale_x_log10() + scale_y_log10()
- })
- expect_doppelganger("rowData bin2d with subset and default legend", {
- plotRowDataBin2D(sfe_cosmx, "means", "vars", subset = "is_neg",
- bins = 50) +
- scale_x_log10() + scale_y_log10()
- })
- expect_doppelganger("colData bin2d for multiple samples", {
- plotColDataBin2D(sfe_cosmx2, "nCounts", "nGenes",
- facet_by = "sample_id")
- })
- expect_warning(plotColDataBin2D(sfe_cosmx, "nCounts", "nGenes",
- facet_by = "nCounts"),
- "Not facetting")
  expect_warning(plotColDataBin2D(sce = sfe_cosmx, x = "nCounts",
  y = "nGenes"),
  "deprecated")